Contrib.social

Move commerce product management into another module

Open on Drupal.org →
Created on 15 December 2023, about 1 year ago
Updated 22 February 2024, about 1 year ago

Problem/Motivation

Including Commerce product management conditionally as we have done so far has disadvantages:

  • We can't test this part since commerce_product is not in the dependencies
  • Phpstan is reporting errors such as "Parameter $commerce_product of function [function]() has invalid type Drupal\commerce_product\Entity\Product." for the same reason

Proposed resolution

Since it's not possible to handle submodules dependencies on a Composer level (https://drupal.stackexchange.com/questions/318414/handle-module-dependen...), I'll build an index_now_commerce module instead and therefore I'll drop commerce products management from index_now main module in 3.0.x

Remaining tasks

User interface changes

The main change will be that websites using Index Now for commerce products will need to enable that new module

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇫🇷France MacSim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024