Add support for metatag to 2.x

The last submitted patch, 2: lupus_ce_renderer-upgrade_metatag-3409045-2.patch, failed testing. View results →

junkuncz → closed merge request !32

Patch has been updated. Give the chance to composer to select which version is preferred
metatag_generate_entity_all_tags() was introduced in 1.23 so that should be the minimum compatibility now.

@junkuncz thank you for you PR.

I've quickly checked changed files and I've noticed that in the CustomElementsMetatagsGenerator there is MetatagManager service injected but never used. Either this should go out we use it instead of the deprecated metatag_generate_entity_metatags function.

I've quickly checked: https://git.drupalcode.org/project/metatag/-/blob/2.0.x/metatag.module?r... metatag_generate_entity_all_tags should be used because it also provides the alter hook and the manager does not.

Plz just drop the metatagManager service since it is not used in the class.

@useernamee thank you for the review and your remarks.

I've added a new patch including your request and I also cleaned up the module running phpcs (except README.md)

This looks all good. Which version is used on CI now?
If we need to change our test-dependencies to make it use metatag v2 as well, I think we should do it. Please take a look. Else this seems ready to go!

improving issue title to reflect both are going to work. Is this correct? (if not we must change composer deps)

@fago thank you for your feedback.
As I see CI is using the upgraded version: https://dispatcher.drupalci.org/job/drupal8_contrib_patches/180057/console

"Installing drupal/metatag (2.0.0): Extracting archive"

Yes, you are correct both are going to work.

( I did a check that the MR == the patch that "looks all good" per #12. )

thx, merged

Automatically closed - issue fixed for 2 weeks with no activity.