4.3.1 on Drupal 9.5.11 installs solarium 6.x-dev-b785b8b

Created on 14 December 2023, 11 months ago
Updated 21 May 2024, 6 months ago

Respect the submission guidelines above! Drupal.org issue forks cause additional work for the project maintainer!

Setup

  • Solr version:N/A
  • Drupal Core version:9.5.11
  • Search API version: 1.31
  • Search API Solr version: 4.3.1
  • Configured Solr Connector:Standard

Issue

I went to update from 4.3.0 to 4.3.1 on a D9.5.11 site and while the update went through with -W I noticed that solarium was installed with a dev point, which I found odd.

This is the commit https://github.com/solariumphp/solarium/commit/b785b8b and it's rather old.

I assumed this was a dependency issue and from what I could gather it's symfony/event-dispatcher: ^5.0 || ^6.0. With search_api_solr 4.3.0 solarium 6.3.1 does support symfony/event-dispatcher: ^4.3 || ^5.0 || ^6.0 (source: https://packagist.org/packages/solarium/solarium#6.3.1)

So not sure if this is a bug, and if it's not and symfony/event-dispatcher 4.0 is not supported any more then it means 4.3.1 should not support D9.

I hope is the former as this site will go to D10 soon, but not right now.

Thanks as always!

🐛 Bug report
Status

Fixed

Version

4.3

Component

Code

Created by

🇦🇷Argentina hanoii 🇦🇷UTC-3

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @hanoii
  • 🇦🇷Argentina hanoii 🇦🇷UTC-3
  • 🇦🇺Australia Greg Clout

    Its worth noting that this also causes the module to report that its requirements aren't met in the Drupal Status Report as the module uses the Client::checkMinimal('6.2.3') check. which behind the scenes utilises version_compare(self::getVersion(), $version, '>=')

    This fails as 6.x-dev is not seen as >= 6.2.3

    The message presented is: Solarium @version is too old!

  • 🇦🇷Argentina hanoii 🇦🇷UTC-3

    6.x-dev is actually a lot older than 6.2.3

  • Status changed to Needs review 11 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 11 months ago
    31 pass
  • 🇩🇪Germany mkalkbrenner 🇩🇪

    Here's a patch for the github action.

  • 🇩🇪Germany mkalkbrenner 🇩🇪

    @Greg Clout, the "issue" in #3 is not related to this one.

  • Status changed to Fixed 11 months ago
  • 🇦🇷Argentina hanoii 🇦🇷UTC-3

    Will this still allow to install 4.3.1 on Drupal 9.5.11?

  • 🇬🇧United Kingdom karengrey

    @hanoii I think theres a wider problem here. Drupal 9.5.11 requires symfony/event-dispatcher-contracts v1.1.13, but a dependency of this module is solarium/solarium which now requires symfony/event-dispatcher-contracts ^2.0 || ^3.0

    Im not sure what the solution is here, as im currently trying to do a Drupal 10 upgrade from 9.5.11, but need to update the modules first

  • 🇩🇪Germany mkalkbrenner 🇩🇪

    The "solution" is to upgrade to Drupal 10 first.
    BTW Drupal 9 reached EOL.

  • 🇦🇷Argentina hanoii 🇦🇷UTC-3

    Understood. Although I'd recommend if that's the case to maybe release a new version with only support for D10.

    Because the fact that 4.3.1 installs but with a very old solarium library it's potentially dangerous, I actually found another project that I didn't upgrade under this same situation. Or maybe fix -dev on composer to match the actual latest so that dev is also not picked up by composer for 4.3.1?

  • 🇩🇪Germany mkalkbrenner 🇩🇪

    D10 support was removed with 4.3.2.

    To allow a dev version to fulfill requirements, there's a module or composer plugin.
    But I didn't use that for a long time. To do such a transition you can use
    composer require solarium/solarium:3.2.1 as 4.5.6 or composer require solarium/solarium:dev-master as 7.8.9

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • 🇪🇸Spain gmoraleb

    Hello @Greg Clout,

    Do you know anything related the comment #3?

    It seems I have the same issue.

Production build 0.71.5 2024