- Issue created by @ultimike
- Issue was unassigned.
- ๐บ๐ธUnited States ultimike Florida, USA
I spent a few hours this morning trying to convert the Auto Login Url moduleโs tests from DrupalCI to GitLabCI to no avail. The tests pass on my local, but fail on GitLabCI. Iโve made a bunch of tweaks to the tests in my efforts, to no avail. For the life of me I canโt figure out what the issue is. I would love a second set of eyes on this...
-mike
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 8:10pm 14 December 2023 - ๐ช๐ธSpain fjgarlin
It was due to paths as drupal is installed in a subdirectory. I fixed a few lines regarding URL generation and also some tests to use absolute URLs.
Last pipeline shows all phpunit jobs fully green so the issue might be marked as Needs review now.
-
ultimike โ
committed 97dbc3ea on 2.x
Issue #3408694 by ultimike, fjgarlin: Switch to GitLab CI for running...
-
ultimike โ
committed 97dbc3ea on 2.x
- Status changed to Fixed
over 1 year ago 7:17am 15 December 2023 - ๐ช๐ธSpain fjgarlin
Just fixing credit as sometimes if #6 and #7 happen too close in time credits might be lost (this is a known issue).
I can see that the checkbox was checked when merging the MR (because the message has both of us populated), but it's missing in the final table of credited people.
- ๐บ๐ธUnited States ultimike Florida, USA
Hmm - @fjgarlin - I'm one of the co-maintainers - how can I fix this?
-mike
- ๐ช๐ธSpain fjgarlin
I think you fixed it in #10 as the checkbox is persisting now.
So everything looks good I think.
Automatically closed - issue fixed for 2 weeks with no activity.