Drupal 10 compatibility issues

Open on Drupal.org →

Created on 13 December 2023, about 1 year ago

Updated 9 March 2024, 9 months ago

Problem/Motivation

Drupal Upgrade Status is reporting 3 issues

Steps to reproduce

Use Drupal Upgrade Status module and scan

Proposed resolution

As I have no clue if these issues are critical please advise how to get the module Drupal 10 compatible.

Here is the result of the scan:

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Webform Attachment Gated Download 8.x-1.4
Scanned on Wed, 12/13/2023 - 19:08.

3 warnings found.

modules/contrib/webform_attachment_gated_download/tests/src/Functional/LoadTest.
php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check │ 14 │ Drupal\Tests\BrowserTestBase::$defaultTheme is required. See │
│ manually │ │ https://www.drupal.org/node/3083055 → , which includes │
│ │ │ recommendations on which theme to use. │
│ │ │ │
│ Check │ 21 │ Property │
│ manually │ │ Drupal\Tests\webform_attachment_gated_download\Functional\Lo │
│ │ │ adTest::$modules property must be protected. │
│ │ │ │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/webform_attachment_gated_download/webform_attachment_gated_downl
oad.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│ STATUS │ LINE │ MESSAGE │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check │ 0 │ Value of core_version_requirement: ^8 || ^9 is not │
│ manually │ │ compatible with the next major version of Drupal core. See │
│ │ │ https://drupal.org/node/3070687. │
│ │ │ │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

✨ Feature request

Status

Closed: duplicate

Version

1.5

Component

Code

Created by

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 12 months ago →
🇮🇳India Pinesh Kumar
Drupal Upgrade Status and coding standards.
Status changed to Needs review 12 months ago5:01am 19 December 2023
Comment 12 months ago →
🇮🇳India Pinesh Kumar
Comment 12 months ago →
🇮🇳India shiks
Above patch is not working as expected
Comment 12 months ago →
🇮🇳India shiks
Here is a new patch file.
Fixed Drupal Upgrade Status warnings and errors.
Comment 12 months ago →
🇮🇳India Sandeep_k New Delhi
Verified and tested patch webform_attachment_gated_download.patch on Drupal version- 10.2.1-dev. The patch was applied successfully with one warning (attached screenshot) and looks good to me.

Testing Steps:

Added Module in Drupal 10.

You can see the module compatibility error in the Extend module. See before screenshot attached

Download this patch and Apply.

Go back to the Extend module and re-verify this.

Testing Results:
After applying the patch, the compatibility error is removed. RTBC +
Status changed to Closed: duplicate 9 months ago11:34am 9 March 2024
Comment 9 months ago →
🇮🇹Italy maurizio.ganovelli Arezzo

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024