Support more payment method types

Correct, only credit card is supported at this time. We do have some other stripe payment methods in the pipeline.

We won't be implementing them all. (At least not in the near term.) But will do so in a way that it would be fairly easy to extend.

Thanks for the quick feedback Tom!

I just wanted to let you know I asked guys from Stripe if, in order to let my customers reuse a previously stored payment method, I needed to implement every stripe.confirmXXXXPayment possibilities from https://stripe.com/docs/js/payment_intents/payment_method
Indeed, since you guys used stripe.confirmCardPayment for credit cards, I thought I was going to need to implement stripe.confirmPayPalPayment for Paypal, stripe.confirmSepaDebitPayment for SEPA Debit, etc.

Here is their answer:
"If you want to charge a saved PaymentMethod later on then you don't need to implement anything client-side except your own UI to indicate which PaymentMethod should be charged
Then you just create/confirm a PaymentIntent server-side to charge that PaymentMethod
https://stripe.com/docs/payments/save-and-reuse?platform=web&ui=elements... is an example of what this would look like"

After reading that piece of documentation, I understand there's still the case where an authentication such as 3DS is required that requires us to use some JS script. However, in this case it seems we can use the generic JS function stripe.confirmPayment using the ClientSecret of the PaymentIntent that requires authentication, no matter what kind of payment method is concerned.
So if I understand correctly, by using server side code first and only use stripe.confirmPayment if necessary, instead of going directly with client-side code such as stripe.confirmCardPayment or stripe.confirmPayPalPayment, it should be easier for us to have generic code that works for all payment method types.

I'm not sure about that however. This is only my early - not tested - understanding. But I thought it might be worth sharing it now if I'm right about it, before you guys decide how you're gonna implement this…

Hi,
I got some update:

On my previous comments, I mentioned that the person from Stripe told me I did not need to do anything client-side, that I could confirm payments server-side only... and require client-side JS action of the customer only if 3DS is required. This is because they thought I wanted to charge the person in off-session mode. But we also need to deal with the client reusing its payment method in on-session mode.

My readings made me believe that stripe.confirmPayment() could be used to confirm any kind of payment client-side, thus removing the need to implement every individual case with stripe.confirmCardPayment for credit cards, stripe.confirmPayPalPayment for Paypal, stripe.confirmSepaDebitPayment for SEPA Debit, etc.

My tests confirm this.

I've just been able to finalize / confirm a payment with a previously stored payment method of type Paypal by simply replacing in commerce_stripe.payment_element.js

stripe.confirmCardPayment(
  settings.clientSecret,
  {
    payment_method: settings.paymentMethod
  }
).then(function (result) {

with

stripe.confirmPayment({
  clientSecret: settings.clientSecret,
  confirmParams: {
    return_url: settings.returnUrl,
    // payment_method: settings.paymentMethod // not even needed since it's already been added to the PaymentIntent
  }
}).then(function (result) {

using the same piece of code, I was able to confirm a payment with a stored credit card as well.

So I can confirm that stripe.confirmPayment() seems indeed generic and allows to confirm all types of payment methods with no need to confirm the payment server-side.

Only difference is, like when using PaymentElement form when adding new payment methods, the Promise never resolves and Stripe redirects us to the return_url. NB: this can be overridden with the 'redirect' parameter when possible if necessary...

So we have to adapt StripePaymentElement->onReturn to not try to save a payment method twice.

BTW as you may have guessed, I have been able to update StripePaymentElement->onReturn so that it can save payment methods other than credit cards. This does not require too much effort. I will probably create another issue to share my code when I'm done.

Hi @Nicolas, Thanks for the request.

We've actually already been working on refactoring in order to handler more than just credit card.

Please take a look at the latest dev, and specifically the MR from this issue: 📌 Refactor Stripe payment element for additional payment method types Fixed , which implements the refactoring.

It seems to align with observations you make here.

Some other payment methods are in the pipeline, but MRs for ones not implemented are welcome!