- Issue created by @axroth
- 🇮🇹Italy mondrake 🇮🇹
We need to fix this and push out a new release. I'd definitely would like to have some test coverage for the case when this property is accessed not being initialized yet, need to figure out the case.
- Status changed to Needs work
about 1 year ago 1:59pm 13 December 2023 - 🇮🇹Italy mondrake 🇮🇹
@axroth I wouldn't like to revert the typehinting, rather ensure the case of uninitialized property be gracefully handled in the getters. See MR. We need test coverage, though.
- 🇩🇪Germany axroth Stuttgart
@mondrake absolutely! Like your solution. For tests I cannot help I think.
- 🇮🇳India rakesh.nimje84@gmail.com
Merge request !21 changes are working like a charm!
- 🇮🇹Italy mondrake 🇮🇹
OK, so this definitely happens if the toolkit parses an invalid image, and
::getWidth()
is called without prior checking::isValid()
, which should not happen in theory. But as someone said,"A little experience often upsets a lot of theory."
Waiting for RTBC by someone that has had the issue before committing and pushing a release, thanks.
- Status changed to Needs review
about 1 year ago 2:11pm 14 December 2023 - Status changed to RTBC
about 1 year ago 8:51am 15 December 2023 -
mondrake →
committed edbb8f2d on 8.x-3.x
Issue #3408403 by mondrake, axroth: ImagemagickToolkit::$width must not...
-
mondrake →
committed edbb8f2d on 8.x-3.x
- Status changed to Fixed
about 1 year ago 9:11am 15 December 2023 -
mondrake →
committed 619f918f on 4.0.x
Issue #3408403 by mondrake, axroth: ImagemagickToolkit::$width must not...
-
mondrake →
committed 619f918f on 4.0.x
Automatically closed - issue fixed for 2 weeks with no activity.