Contrib.social

Improve test coverage

Open on Drupal.org →
Created on 13 December 2023, about 1 year ago
Updated 13 March 2024, 12 months ago

Problem/Motivation

Test coverage for the module is lacking. Only some of the module's features have tests on them. Without adequate test coverage, simple regression or bugs can sneak into the code while fixing issues, or unintentional consequences to existing functionality missed.

Steps to reproduce

Review the tests in the module and compare to the available features.

Proposed resolution

Add tests for all existing features.

Remaining tasks

  • ✅ File an issue
  • ✅ Add tests for existing issues
    • ✅ Decorating core password_generator
    • ✅ Configured password length
    • ✅ Password generated uses char sets as expected
    • ✅ Pass thru to core generate's correct password and switch works
    • ✅ Altering character sets
    • ✅ Caching of altered char sets
    • ✅ Checks on bad alter throw exceptions
    • ✅ Action to set new user password
    • ✅ Using Genpass on custom form using custom fields
    • ✅ Tokens added for user password
  • ✅ Review existing tests
    • ✅ Remove "toolbar" as testing requirement as it did not impact testing
  • ✅ Merge tests into 2.1.x branch
  • ➖ Code review by maintainers
  • ➖✅ Credit contributors
  • ✅ Release notes snippet
  • ❌ Release: Deferred until anything else to release, 6 months, or D11 release.

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Added tests for features:

  • Decorating core password_generator
  • Configured password length
  • Password generated uses char sets as expected
  • Pass thru to core generate's correct password and switch works
  • Altering character sets
  • Caching of altered char sets
  • Checks on bad alter throw exceptions
  • Action to set new user password
  • Using Genpass on custom form using custom fields
  • Tokens added for user password
📌 Task
Status

Fixed

Version

2.1

Component

Code

Created by

🇦🇺Australia elc

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024