Created on 12 December 2023, 10 months ago
Updated 2 April 2024, 6 months ago

Problem/Motivation

Moving images using the arrows key does not work for the first and last photo of Splidebox.
Splidebox does not close itself with Esc key :(

Steps to reproduce

Edit Splide optionset: Splidebox

  • Type: Slide
  • Keyboard: True
🐛 Bug report
Status

Fixed

Version

2.0

Component

User interface

Created by

🇨🇿Czech Republic hop

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @hop
  • 🇮🇩Indonesia gausarts

    Thank you.

    Does keyboard arrows work at their site samples?
    If yes, might be a bug in this module. If no, please report it to the github library issues.

    Regarding closing on Escape, this one is an obvious lack of features in this module.

  • 🇨🇿Czech Republic hop

    No, keyboard arrows do not work in Splide library see https://github.com/Splidejs/splide/issues/1257 (pardon, my mistake).

  • Status changed to Fixed 6 months ago
  • 🇮🇩Indonesia gausarts

    > Splidebox does not close itself with Esc key
    This should be added or fixed in 2.0.3.

    For other keyboard issues, they might be Splide library bugs as you noticed we can do nothing about here, I am afraid.
    Github project issues is the way to fix them.

    Thank you.

  • Status changed to Active 6 months ago
  • 🇮🇩Indonesia gausarts

    I just noticed the Splide library migration from 3 appeared to be incomplete.
    The Keyboard option missed 'global' option which should trigger the keyboard event, but not true value.

    At least the global trigger it correctly:
    https://splidejs.com/guides/options/#keyboard

    Moving this to Splide module for the fix.
    In the meantime, you can use the provided hook_alters to change the value to global.

  • Status changed to Needs review 6 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7 updated deps
    last update 6 months ago
    18 pass
  • 🇮🇩Indonesia gausarts

    Choosing global for the Keyboard does the keyboard right, except for the last or first slide if choosing Slide or likely Fade under Type option which makes sense since they don't loop.

  • Status changed to Fixed 6 months ago
  • 🇮🇩Indonesia gausarts

    This new global value will do for now.

    There are other missing or new options need updating to account for v4, but that will be done later along the way.

    Thank you.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024