- Issue created by @geek-merlin
-
jsacksick →
committed efcb05e2 on 8.x-2.x
Issue #3407714 by geek-merlin: Require IEF ^1 || ^3.
-
jsacksick →
committed efcb05e2 on 8.x-2.x
-
jsacksick →
committed 74bbaba0 on 3.0.x
Issue #3407714 by geek-merlin: Require IEF ^1 || ^3.
-
jsacksick →
committed 74bbaba0 on 3.0.x
- Status changed to Fixed
over 1 year ago 5:39am 11 December 2023 - Status changed to Active
over 1 year ago 2:31pm 18 December 2023 - 🇮🇱Israel jsacksick
@geek-merlin: It seems that tests started to fail since I committed this change... I'm thinking it should be reverted...
- 🇩🇪Germany geek-merlin Freiburg, Germany
> It seems that tests started to fail since I committed this change...
@jsacksick: Can you clarify?
I go to https://www.drupal.org/node/605898/qa → , and see everything green. - 🇮🇱Israel jsacksick
See https://git.drupalcode.org/project/commerce/-/pipelines:
The first one that failed is https://git.drupalcode.org/project/commerce/-/pipelines/61909. (right after this commit).
- 🇩🇪Germany geek-merlin Freiburg, Germany
Gee! I can confirm that. So it shows up in the gitlab pipeline but not in DrupalCI? Whatever.
Found a weird thing in the releated issue, the tags point to the same commit, but d.o packagist thinks otherwise.
I wasted two RC figures and they finally match. Spooky. But now we have both packagist semvers identical.Let's see what happens. Do you have the power to re-trigger the pipeline?
- 🇮🇱Israel jsacksick
Was there a reason to not stick with just 1.x? If the code is the same in 3.x? What was the reason for introducing another branch if the code is the same?
- 🇮🇱Israel jsacksick
Pipelines are still failing, FYI: https://git.drupalcode.org/project/commerce/-/jobs/510328.
- Merge request !214Issue #3407714: Revert to requiring IEF 1.0 to fix pipelines. → (Closed) created by jsacksick
- last update
over 1 year ago 787 pass - Status changed to Fixed
over 1 year ago 9:33am 27 December 2023 - 🇮🇱Israel jsacksick
Closing this, the test failures are no longer related to IEF it seems :).
- 🇩🇪Germany geek-merlin Freiburg, Germany
Thx!
As of
Was there a reason to not stick with just 1.x? If the code is the same in 3.x?
See 📌 Clean up problematic 2.x branch Active and 📌 Revoke InlineEntityForm maintainership privileges of @podarok Fixed . Highly non-technical issue. PMed with Ryan about that.
Automatically closed - issue fixed for 2 weeks with no activity.