- Issue created by @Dave Reid
- Merge request !35Cleanup plugins to remove constructors and only use create() to inject additional services. → (Merged) created by Dave Reid
-
Dave Reid →
committed a795a0c8 on 8.x-2.x
Issue #3407702 by Dave Reid: Clean up plugins to always use create() and...
-
Dave Reid →
committed a795a0c8 on 8.x-2.x
- Status changed to Fixed
7 months ago 3:33pm 11 December 2023 - 🇺🇸United States mikeryan Murphysboro, IL, USA
Yes, good practice. But this is a breaking change for applications which overrode the now-absent constructors - it would have been nice to bump the major version in this case.
- 🇺🇸United States Dave Reid Nebraska 🇺🇸
Plugin constrictors have always been internal and not APIs, even for core. Sorry this should have potentially been flagged as possibly causing that. I'm not sure we can do anything at this point.
- 🇺🇸United States mikeryan Murphysboro, IL, USA
Yep, what's done is done. Good motivation for us to do as you did here and get away from old-school inheritance...
Automatically closed - issue fixed for 2 weeks with no activity.