Update: drupal/core:9.5.11

Wim Leers → credited slasher13 → .

I followed the official handbook page for this process →

1. Step 1: no issues.
2. Step 2:

   1. Applying https://www.drupal.org/files/issues/2022-12-20/3204212-field-migration-widget-formatter-mapping-52--fix-only.patch …
      patching file core/modules/datetime/src/Plugin/migrate/field/DateField.php
      patching file core/modules/field/migrations/d6_field_formatter_settings.yml
      patching file core/modules/field/migrations/d6_field_instance_widget_settings.yml
      Hunk #2 FAILED at 45.
      1 out of 2 hunks FAILED -- saving rejects to file core/modules/field/migrations/d6_field_instance_widget_settings.yml.rej
      patching file core/modules/field/migrations/d7_field_instance_widget_settings.yml
      patching file core/modules/field/src/Plugin/migrate/field/Email.php
      patching file core/modules/field/src/Plugin/migrate/field/d7/EntityReference.php
      patching file core/modules/file/src/Plugin/migrate/field/d6/FileField.php
      patching file core/modules/file/src/Plugin/migrate/field/d7/FileField.php
      patching file core/modules/image/image.module
      patching file core/modules/image/src/Plugin/migrate/field/d6/FileField.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/FieldPluginBase.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d6/NodeReference.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d6/NumberDecimalField.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d6/NumberFloatField.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d6/NumberIntegerField.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d6/UserReference.php
      patching file core/modules/migrate_drupal/src/Plugin/migrate/field/d7/Boolean.php
      patching file core/modules/taxonomy/src/Plugin/migrate/field/TaxonomyTermReference.php
      patching file core/modules/telephone/src/Plugin/migrate/field/d6/PhoneField.php
      patching file core/modules/telephone/src/Plugin/migrate/field/d7/PhoneField.php
      patching file core/modules/text/src/Plugin/migrate/field/d6/TextField.php
      

      👆 Thankfully @slasher13 already provided a reroll: #3204212-57: Convert remaining widget and formatter type migrations to MigrateField plugins → . Credited him.

   2. Updated the patch to point to the new one, and tried again. Next failure:
      

      Applying https://www.drupal.org/files/issues/2020-04-08/2985882-field-85.patch …
      patching file core/modules/layout_builder/src/Plugin/Derivative/FieldBlockDeriver.php
      Reversed (or previously applied) patch detected!  Assume -R? [n] 
      

      👆 Looks like 💬 Workaround for "Call to a member function getLabel() after enabling layout_builder" Fixed actually was committed after 9.5.8?! 😄 Yes, it was: #2985882-164: Workaround for "Call to a member function getLabel() after enabling layout_builder" → . And shipped in 9.5.9: https://www.drupal.org/project/drupal/releases/9.5.9 → — yay one fewer core patch to maintain!

   3. Removed that patch, tried again … and success! 🥳

Looks like there's some GitLab CI infrastructure instability… requeued the 2 failed test jobs that failed with similar errors (while other identical tests against different PHP versions worked just fine).

#6 was solved in 🐛 GitLab CI pipeline broke due to wodby/php:8.1-dev 4.41.0 installing XDebug 3.3 Needs review . Rebasing this and then retrying…

So this part is done now:

1. MR against the recommendations branch to update recommendations.json to use https://www.drupal.org/project/drupal/releases/9.5.11 →
2. Verify the recommendations tests pass in GitLab CI

Next up:

<ol start=3>
  <li>MR against the <code>1.8.x

(module) branch to pin the module to this new branch