- Issue created by @manuel garcia
- π¬π§United Kingdom oily Greater London
andrew.farquharson β made their first commit to this issueβs fork.
- π¬π§United Kingdom oily Greater London
- I add a .gitlab-ci.yml file to the project root using the contents of the Drupal Association's template.gitlab-ci.yml.
- Committed the file to the issue branch
- On commit the pipeline was triggered automatically and ran the tests
- The PHPUnit tests terminated with one failure.
I think a new issue should be created to fix the failing test.
Further investigation of the test failure can be carried out under this ticket to make sure that the failure is due to a test error: that the tests have reported the error correctly. That is proof that the pipleline is working correctly.
- Status changed to Needs review
about 1 year ago 1:20am 7 December 2023 - Status changed to Postponed
about 1 year ago 4:19pm 7 December 2023 - πͺπΈSpain manuel garcia
Thanks, I'm learning about this as I go, but as far as I can tell the build failed with:
Unable to install modules: module 'view_profiles_perms_test' is incompatible with this version of Drupal core.
- and its using Drupal version : 10.1.8-devSo indeed this is a bug, we (I) forgot to upgrade to Drupal 10 the module we use in the test to setup things.
I've created π view_profiles_perms_test not compatible with Drupal 10 Fixed for the same, postponing this until we get that fixed, so we can get tests actually running on Gitlab.
- π¬π§United Kingdom oily Greater London
@Manuel Ah, that makes sense.
- Status changed to Active
about 1 year ago 8:55am 11 December 2023 - πͺπΈSpain manuel garcia
We now have a passing 2.1.x branch, so we can proceed with this.
- π¬π§United Kingdom oily Greater London
Hi @Manuel Garcia, I am not sure if the gitlab configuration just needs to work for Drupal 10 and if not which versions of Drupal core the tests need to be tested on.. Also does the gitlab configuration it the .gitlab-ci.yml just need to be compatible with the 2.1.x branch or with other branches also?
- last update
about 1 year ago 1 pass - πͺπΈSpain manuel garcia
Let's bring in the phpstan.neon file from the PR we worked on for π view_profiles_perms_test not compatible with Drupal 10 Fixed , it should take care of this warning: https://git.drupalcode.org/issue/view_profiles_perms-3406407/-/jobs/475158
Re @andrew.farquharson #8
Hi @Manuel Garcia, Since branch 2.1.x has core compatibility with Drupal 9 and 10 I am not sure if the .gitlab-ci.yml needs to be edited to test on Drupal 9 and 10 versions? I imagine that the scope of this ticket is to make changes only to the .gitlab-ci.yml. The functional test is now fixed so it should work on Drupal 9 and 10, now? Is there anything i am missing?
I'm not entirely sure if we need to customize our .gitlab-ci.yml file to be honest, I had a read of https://www.drupal.org/node/3356364 β and couldnt figure it out. You are right in that we should be testing with both supported Drupal core versions though.