- Issue created by @t.maquin
- Status changed to Needs review
11 months ago 10:39am 23 December 2023 - last update
11 months ago 544 pass, 1 fail - last update
11 months ago 545 pass - π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for reporting this problem!
Itβs actually even more serious: it seems the problem is not with missing values (those are handled fine), but with values that donβt contain any tokens. Can you confirm that a field like that is present in your index?
(Seems like I was pretty sloppy in reviewing once again, the IDE even displays a warning that the variable might be undefined.)Anyways, the attached patches both demonstrate the problem (with a regression test) and provide a solution. Please test/review!
The last submitted patch, 2: 3406283-2--custom_value_processor_value_wo_tokens--tests_only.patch, failed testing. View results β
- π«π·France t.maquin
Thanks for your response !
Your patch does the work and yes, i needed to have two custom fields on my index that does not contain any tokens.
I handle theses fields with a custom processor to set specific values in it.Your patch should be applied to the contrib.
- Status changed to RTBC
11 months ago 9:40am 4 January 2024 -
drunken monkey β
committed ac9a698b on 8.x-1.x
Issue #3406283 by drunken monkey: Fixed "undefined variable" warning in...
-
drunken monkey β
committed ac9a698b on 8.x-1.x
- Status changed to Fixed
11 months ago 5:16pm 6 January 2024 - π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for reporting back, good to hear it worked.
Merged. Thanks again! Automatically closed - issue fixed for 2 weeks with no activity.