- Issue created by @franckylfs
- Status changed to Needs work
about 1 year ago 10:55pm 7 December 2023 if (!$params || !$query_string) {
is exactly the same asif (!$params || ($params && !$query_string)) {
, so that would be shorter if it works.- Merge request !4Allow if no params in URL or none in configuration. → (Open) created by solideogloria
- Status changed to Needs review
7 months ago 8:59pm 14 May 2024 Marking this issue as Major, since it would prevent most potential uses of this module altogether.
- 🇨🇦Canada franckylfs Montreal
Thanks! I approve, but I think I can't do it on git.drupalcode.org. Sorry :(
- Status changed to RTBC
7 months ago 1:50pm 15 May 2024 - Assigned to solideogloria
- Status changed to Needs work
7 months ago 1:51pm 15 May 2024 - Status changed to Needs review
7 months ago 2:32pm 15 May 2024 The
requestAffected()
function didn't have any tests for it at all! I added test coverage for the entire function, not just for the changed functionality.It's a good thing I spent time last week reading about how phpspec/prophecy works, because the module's tests use it a lot.
Adding as a related issue, since I fixed its failing phpunit test here.
- Issue was unassigned.