Invalid json in composer file

I have updated the .json file & added patch, please review.

Yes, that looks much better :-)

Thanks for this nice module and getting it Drupal 10 compatible!

I am changing this to the development branch.

MR! 4 looking good to me. Thanks!

Sorry for messing up, doing things in a hurry is never a good idea. Thanks for the patch, committed and pushed to 2.1.x - Please verify and I will cut a new tag.

@Manuel Garcia, Thank you for committing the patch, but there is an error in the composer.json that remains. That error is fixed in MR!4. The error is the drupal/core version which does not match the version in the .info.yml. That could cause problems. I provide a link to these problems in the docs in the description of this issue, which I edited.

@andrew.farquharson this is already fixed in the 2.1.x branch:

https://git.drupalcode.org/project/view_profiles_perms/-/blob/2.1.x/comp...

  "require": {
    "drupal/core": "^9 || ^10"
  }

https://git.drupalcode.org/project/view_profiles_perms/-/blob/2.1.x/view...
core_version_requirement: ^9 || ^10

I've just switched the default branch of the project to 2.1.x in order to avoid future confusion and tagged a new 2.1.1 release with this fix.

Manuel Garcia → closed merge request !4

Manuel Garcia → closed merge request !5

Hi @manuelgarcia. Thank you for closing the ticket. I enabled the Gitlab CI because it seemed otherwise my MR would not be tested. Was not sure how to set it up true! Thank you for the link: need to read up on it. I thought i would get credit for noticing the discrepancy between the core drupal versions between composer.json and the info.yml. Since my MR's have not been used I am not sure how the commit was incorporated? Did you create an ad hoc commit? I thought it was reasonable to fix that under the 'malformed composer.json' description of this issue. So I expected to receive credit. A bit discouraging otherwise..

Apologies @andrew.farquharson - i have now pushed an empty commit to rectify the commit mentions for this ticket.

Thank you Manuel!

Automatically closed - issue fixed for 2 weeks with no activity.