- Issue created by @zniki.ru
- last update
over 1 year ago 31 pass - Issue was unassigned.
- 🇷🇺Russia zniki.ru
PHPunit fails because solr server is not available.
I will research if it's possible now to use solr with gitlab ci. - 🇪🇸Spain fjgarlin
I haven't done solr yet, but you'd need to define a service (https://docs.gitlab.com/ee/ci/services/) that will create the solr instance, and then you should be able to access it by the "alias" you gave the service.
- 🇩🇪Germany cspitzlay 🇩🇪🇪🇺
That's the reason why search_api_solr tests did not really use drupalCI but ran on github.
But maybe now, with gitlab CI, it will be possible to use the drupal infrastructure. - 🇩🇪Germany mkalkbrenner 🇩🇪
In fact you need to port this to gitlab CI:
https://git.drupalcode.org/project/search_api_solr/-/blob/4.x/.github/wo... - 🇷🇺Russia zniki.ru
Thanks a lot for your suggestion, I didn't know that module's tests runs on Github.
It is good idea to disable PHPunit tests in Gitlab CI for now and create follow up issue?There are several linting issues in the module and it would be great to have lint check, at least for the issue 📌 Fix the issues reported by phpcs Needs work .
- 🇩🇪Germany mkalkbrenner 🇩🇪
mkalkbrenner → changed the visibility of the branch 3405415-adopt-gitlabci to hidden.
- last update
over 1 year ago 31 pass - Status changed to Needs review
over 1 year ago 5:21am 5 December 2023 - 🇷🇺Russia zniki.ru
As .gitlab-ci.yml is already in the code base, I removed adding it, and only phpstan.neon left in the MR.
Can you please make a review MR 28. - last update
over 1 year ago 31 pass -
mkalkbrenner →
committed ad88dba5 on 4.x authored by
zniki.ru →
Issue #3405415 by zniki.ru, mkalkbrenner: Adopt GitlabCi
-
mkalkbrenner →
committed ad88dba5 on 4.x authored by
zniki.ru →
- 🇩🇪Germany mkalkbrenner 🇩🇪
I opened a follow-up: 📌 Migrate GitHub actions to GitLab CI Active
- Status changed to Fixed
over 1 year ago 3:10pm 5 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.