Modal layout is broken if the Claro theme is not installed/set as administration theme

Created on 29 November 2023, 12 months ago
Updated 23 January 2024, 10 months ago

Problem/Motivation

The modal layout is broken because when the Claro theme is not installed or it's not set as administration theme, all variables which are defined in the variables.css of the Claro theme are not loaded to use in the styling of this module.

Steps to reproduce

Installing this module and dependencies without Claro theme or Claro theme is not set as administration theme.

Proposed resolution

Coping content in the variables.css of the Claro theme to paste into paragraphs_ee.categories.scss.

🐛 Bug report
Status

Closed: won't fix

Version

10.0

Component

Code

Created by

🇻🇳Vietnam phannphong Ho Chi Minh City

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @phannphong
  • Status changed to Postponed: needs info 11 months ago
  • 🇩🇪Germany stborchert

    How did you manage to get the "Add-in-between" buttons working without using Claro (at least as the base theme for your theme)?
    Paragraphs Features requires this patch 🐛 Add-in only works if active theme is claro or gin RTBC to make the buttons work in subthemes of Claro or Gin. Other themes won't work.

  • 🇻🇳Vietnam phannphong Ho Chi Minh City

    Hi stBorchert, the patch 🐛 Add-in only works if active theme is claro or gin RTBC from MR 12, can work without Claro or Gin enables so in my project, I applied above patch for Paragraphs Features and apply this patch for Paragraphs Editor Enhancements.

  • Status changed to Closed: won't fix 11 months ago
  • 🇩🇪Germany stborchert

    Sorry, but that won't work. I will not ship Paragraphs EE with a complete copy of Claro's styles.
    Paragraphs Features is not built to work with themes not depending on Claro and so will Paragraphs EE. Maybe optionally loading the required libraries from Claro would do but I believe this will break other stuff.

  • 🇻🇳Vietnam phannphong Ho Chi Minh City

    Yes, I agree with you because the patch will break some other stuffs. I have to back with the theme based on Claro.

Production build 0.71.5 2024