storeAcceptedCode()/alreadyAcceptedCode should check token id.

Created on 25 November 2023, 12 months ago

Problem/Motivation

We currently store codes assuming that no two plugins will ever generate the same code.

This is a inaccurate assumption.

Addtionaly we prevent plugins from cleaning up codes that no longer need to be stored as a plugin may not be able to determine if a code is one of its own. see πŸ’¬ Cleanup accepted codes stored in user data Postponed

Steps to reproduce

Proposed resolution

Add the plugin name when storing accepted codes.
Check for a hash existing with the plugin name and without the plugin name for BC.

Remaining tasks

User interface changes

None

API changes

TBD

Data model changes

An id will be stored with each hash.

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States cmlara

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @cmlara
  • πŸ‡ΊπŸ‡ΈUnited States cmlara

    Changing this from plugin name to a token id.

    Plugins may want to offer multiple tokens as such the plugin id alone would not be sufficient.

Production build 0.71.5 2024