- Issue created by @trickfun
- First commit to issue fork.
- Status changed to Needs review
7 months ago 8:39am 22 November 2023 - last update
7 months ago 2 pass - 🇮🇳India viren18febS
Hi @trickfun
I have fixed the issue & added patch, please review. - 🇮🇹Italy trickfun
Patch works fine but when i try to save payment i get this new error
TypeError: Drupal\commerce_paypal\Plugin\Commerce\PaymentGateway\Checkout::createPaymentMethod(): Argument #2 ($payment_details) must be of type array, null given, called in /var/www/html/web/modules/contrib/commerce/modules/payment/src/PluginForm/PaymentMethodAddForm.php on line 83 in Drupal\commerce_paypal\Plugin\Commerce\PaymentGateway\Checkout->createPaymentMethod() (line 842 of modules/contrib/commerce_paypal/src/Plugin/Commerce/PaymentGateway/Checkout.php). Drupal\commerce_payment\PluginForm\PaymentMethodAddForm->submitConfigurationForm(Array, Object) (Line: 104) Drupal\commerce_paypal\PluginForm\Checkout\PaymentMethodAddForm->submitConfigurationForm(Array, Object) (Line: 169) Drupal\commerce_payment\Plugin\Commerce\InlineForm\PaymentGatewayForm->submitInlineForm(Array, Object) (Line: 159) Drupal\commerce\Plugin\Commerce\InlineForm\InlineFormBase::runSubmit(Array, Object) call_user_func_array(Array, Array) (Line: 141) Drupal\commerce\Plugin\Commerce\InlineForm\InlineFormBase::doExecuteSubmitHandlers(Array, Object) (Line: 134) Drupal\commerce\Plugin\Commerce\InlineForm\InlineFormBase::doExecuteSubmitHandlers(Array, Object) (Line: 86) Drupal\commerce\Plugin\Commerce\InlineForm\InlineFormBase::executeElementSubmitHandlers(Array, Object) call_user_func_array(Array, Array) (Line: 82) Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object) (Line: 275) Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'commerce_payment_method_add_form') (Line: 118) Drupal\Core\Form\FormValidator->validateForm('commerce_payment_method_add_form', Array, Object) (Line: 593) Drupal\Core\Form\FormBuilder->processForm('commerce_payment_method_add_form', Array, Object) (Line: 325) Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73) Drupal\Core\Controller\FormController->getContentResult(Object, Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
- 🇮🇱Israel jsacksick
@trickfun: Well, PayPal checkout doesn't support card tokenization if that is what you're trying to do... So saving the payment method from the user pages isn't supported.
- 🇮🇹Italy trickfun
Fine.
But why if i try to add payment i get paypal options available? -
jsacksick →
committed 23ef4bf9 on 8.x-1.x
Issue #3403214 by viren18febS, jsacksick: Drupal\commerce_paypal\...
-
jsacksick →
committed 23ef4bf9 on 8.x-1.x
- Status changed to Fixed
6 months ago 3:29pm 2 January 2024 - 🇮🇱Israel jsacksick
Committed a slightly different patch, but again the payment method tokenization isn't supported.
Automatically closed - issue fixed for 2 weeks with no activity.