PHPStan finishes with errors

Created on 21 November 2023, 7 months ago

Problem/Motivation

Latest run (as of issue creation) on the 1.x-dev branch.

------ ----------------------------------------------------------------- 
  Line   src/OrangeDamMigrationDataManager.php                            
 ------ ----------------------------------------------------------------- 
  128    Call to deprecated method setTrackLastImported() of class        
         Drupal\migrate\Plugin\MigrationInterface:                        
         in drupal:10.1.0 and is removed from drupal:11.0.0. There is no  
         replacement.                                                     
 ------ ----------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Derivative/OrangeDamMigrationQueues.php                            
 ------ ------------------------------------------------------------------------------ 
  38     Unsafe usage of new static().                                                 
         πŸ’‘ See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/QueueWorker/OrangeDamDeletionQueueWorker.php                       
 ------ ------------------------------------------------------------------------------ 
  40     Unsafe usage of new static().                                                 
         πŸ’‘ See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/migrate/process/OrangeDamProcessBase.php                           
 ------ ------------------------------------------------------------------------------ 
  45     Unsafe usage of new static().                                                 
         πŸ’‘ See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------- 
  Line   orange_dam.install                                                 
 ------ ------------------------------------------------------------------- 
  14     Variable $contentTypes in empty() always exists and is not falsy.  
  35     Variable $contentTypes in empty() always exists and is not falsy.  
 ------ -------------------------------------------------------------------

Proposed resolution

Resolve PHPStan issues.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States markdorison

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Pipeline finished with Skipped
    9 months ago
    #21029
  • Pipeline finished with Skipped
    9 months ago
    #27600
  • Pipeline finished with Skipped
    8 months ago
    #44370
  • Issue created by @markdorison
  • Status changed to Needs work 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States markdorison
  • πŸ‡ΊπŸ‡ΈUnited States markdorison
  • Status changed to Needs review 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States markdorison

    PHPStan is now passing with no errors.

  • Status changed to RTBC 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States adamzimmermann
  • Status changed to Fixed 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States markdorison
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Skipped
    6 months ago
    #71282
  • Pipeline finished with Skipped
    5 months ago
    #83056
  • Pipeline finished with Canceled
    5 months ago
    Total: 75s
    #86326
  • Pipeline finished with Success
    5 months ago
    Total: 275s
    #86327
  • Pipeline finished with Success
    5 months ago
    Total: 175s
    #92739
  • Pipeline finished with Success
    4 months ago
    Total: 157s
    #95770
  • Pipeline finished with Failed
    4 months ago
    Total: 15461s
    #98041
  • Pipeline finished with Failed
    4 months ago
    #98173
  • Pipeline finished with Skipped
    4 months ago
    #102676
  • Pipeline finished with Failed
    4 months ago
    #102691
  • Pipeline finished with Failed
    4 months ago
    #102690
  • Pipeline finished with Failed
    4 months ago
    Total: 875s
    #108390
  • Pipeline finished with Success
    3 months ago
    Total: 762s
    #122308
  • Pipeline finished with Success
    3 months ago
    Total: 365s
    #143532
  • Pipeline finished with Skipped
    3 months ago
    #143542
  • Pipeline finished with Success
    3 months ago
    Total: 260s
    #145133
  • Pipeline finished with Skipped
    3 months ago
    #145140
  • Pipeline finished with Success
    2 months ago
    Total: 557s
    #151688
  • Pipeline finished with Failed
    2 months ago
    Total: 185s
    #157444
  • Pipeline finished with Failed
    2 months ago
    Total: 155s
    #157462
  • Pipeline finished with Skipped
    2 months ago
    #159912
  • Pipeline finished with Success
    about 2 months ago
    Total: 39s
    #162510
  • Pipeline finished with Success
    about 2 months ago
    Total: 138s
    #163824
  • Pipeline finished with Success
    about 2 months ago
    #163828
  • Pipeline finished with Success
    about 2 months ago
    Total: 172s
    #166143
  • Pipeline finished with Failed
    about 2 months ago
    Total: 181s
    #166428
  • Pipeline finished with Failed
    about 2 months ago
    #167978
  • Pipeline finished with Skipped
    about 2 months ago
    #168068
  • Pipeline finished with Failed
    about 1 month ago
    Total: 638s
    #176009
  • Pipeline finished with Failed
    about 1 month ago
    Total: 195s
    #176011
  • Pipeline finished with Success
    about 1 month ago
    Total: 188s
    #178872
  • Pipeline finished with Success
    about 1 month ago
    Total: 367s
    #180811
Production build 0.69.0 2024