- Issue created by @markdorison
- Status changed to Needs work
12 months ago 10:03pm 20 November 2023 - Status changed to RTBC
12 months ago 10:17pm 20 November 2023 -
markdorison →
committed 30348ddf on 8.x-1.x
Issue #3402952 by markdorison: PHPStan checks result in warnings
-
markdorison →
committed 30348ddf on 8.x-1.x
- Status changed to Fixed
12 months ago 10:18pm 20 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 months ago 7:10pm 22 January 2024 - 🇬🇧United Kingdom 2dareis2do
When will these changes be released on the main branch?
- 🇺🇸United States markdorison
@2dareis2do These changes are on the default branch (
8.x-1.x). Are you looking for these in a tagged release? - 🇺🇸United States markdorison
@2dareis2do I am not against making a release, but it would be helpful for me as a maintainer to understand why a tagged release with these changes would be helpful to you.
The changes made since the last tagged release are meant to improve test feedback on Drupal.org and for contributors who have the repository cloned, but I skipped cutting a release as I didn't think they would have any effect for folks who are installing tagged releases for general use.
- 🇬🇧United Kingdom 2dareis2do
If I run the tests locally this issue seems to break them. I don't have the exact message but the command I ran was
../vendor/bin/phpunit -c core --list-groups
- 🇺🇸United States markdorison
@2dareis2do PHPUnit tests are a different area than this issue/commit which has to do with PHPStan. 🐛 PHPUnit tests failing Needs work needs to be resolved for PHPUnit tests to pass.
- 🇬🇧United Kingdom 2dareis2do
Sorry I'm confused.
All I know is this commit fixes problem with running the tests. That's what I would like to see tagged
078e245a
- 🇺🇸United States markdorison
All I know is this commit fixes problem with running the tests. That's what I would like to see tagged
Can you be more specific? Which tests? There are different sets of tests that run on each merge request and commit: phpcs, phpstan, phpunit, eslint, composer-lint. You can see those groups in the screenshot in #6.
This issue (and the commit you mentioned) resolved PHPStan issues to the best of my knowledge and they are passing on the 8.x-1.x branch as of the last commit. If you are seeing PHPStan errors, please create a new issue with those details and the output of the errors you are seeing.
If you are running PHPUnit tests as you mentioned in #14, those failures are detailed in 🐛 PHPUnit tests failing Needs work but assistance is welcome!
- 🇬🇧United Kingdom 2dareis2do
This is the fatal error I was getting when running the following command
../vendor/bin/phpunit -c core --list-groups
PHP Fatal error: Declaration of Drupal\Tests\remote_stream_wrapper_widget\Functional\RemoteStreamWrapperWidgetTest::setUp() must be compatible with Drupal\Tests\BrowserTestBase::setUp(): - 🇬🇧United Kingdom 2dareis2do
The 8.1.x branch has this change, which probably explains why the tests are ok there.
https://git.drupalcode.org/project/remote_stream_wrapper_widget/-/blob/8...
The latest stable release does not.