Unused trusted_redirect.settings service

Created on 20 November 2023, 12 months ago

Problem/Motivation

trusted_redirect.settings service is defined in trusted_redirect.services.yml but then it is not used in code. TrustedRedirectHelpersTrait is instantiating the configuration through config.factory again which is a code duplication.

Proposed resolution

Remove instantiation of trusted_redirect.settings from helpers trait and properly inject it where needed.

https://git.drupalcode.org/project/trusted_redirect/-/blob/8.x-1.x/src/T...

It might suit us better to convert trait into service for isTrustedUrl is still needed.

📌 Task
Status

Active

Version

1.11

Component

Code

Created by

🇸🇮Slovenia useernamee Ljubljana

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024