- Issue created by @roderik
- last update
over 1 year ago 6 pass - Status changed to Needs review
over 1 year ago 11:22am 20 November 2023 - 🇸🇮Slovenia useernamee Ljubljana
Code changes look good to me, but I think it would be good to get a second opinion.
For consistency we could also rename the
custom_elements_prepare_slots_as_web_component
to use plural.
https://git.drupalcode.org/project/custom_elements/-/merge_requests/6/di... - Status changed to Needs work
over 1 year ago 3:58pm 20 November 2023 - 🇦🇹Austria fago Vienna
> drush config:set custom_elements.settings markup_style vue-3
is what is documented in the README and that or the dfeault is probably what people are using.
web_component is what is working atm, so let's use that and avoid changing working options. Given that we should simply correct the broken update custom_elements_update_8202() in 2.x and 3.x to use the correctly working value
web_component
.There is no need to introduce a new update function, everyone who has already run custom_elements_update_8202() worked around the problem already, so let's simply make sure it cannot happy any more in the future.
- last update
over 1 year ago 6 pass - Status changed to Needs review
over 1 year ago 4:04pm 20 November 2023 - Status changed to RTBC
over 1 year ago 3:25pm 21 November 2023 - 🇸🇮Slovenia useernamee Ljubljana
Taking Wolfgang comment into account, moving this into rtbc
- last update
over 1 year ago 6 pass - last update
over 1 year ago 6 pass -
useernamee →
committed 5223cd80 on 3.x authored by
roderik →
Issue #3402813 by roderik, useernamee, fago: markup_style config value...
-
useernamee →
committed 5223cd80 on 3.x authored by
roderik →
- Status changed to Fixed
over 1 year ago 3:27pm 21 November 2023 - Status changed to Needs work
over 1 year ago 10:18pm 26 November 2023 - Status changed to Fixed
about 1 year ago 2:46pm 14 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.