- Issue created by @miksha
- last update
over 1 year ago 16 pass - πΊπΈUnited States luke.leber Pennsylvania
This change looks good. I'll give it a manual test and merge / cut a release by Monday evening if there aren't any glaring issues.
Thanks!
- Status changed to Needs review
over 1 year ago 11:00pm 20 November 2023 - last update
over 1 year ago 16 pass - πΊπΈUnited States luke.leber Pennsylvania
I was able to confirm that #3 improves the visual diff experience (by not stripping out markup), but there are more things wrong, outside of the scope of this issue. We may have to file an upstream bug report and open a follow-up.
Resolved some coding standards violations; if this makes the test bot happy, I'll commit it.
-
Luke.Leber β
authored 8dafa34d on 1.0.x
Issue #3402629 by miksha, Luke.Leber: SVG images are broken with XSS::...
-
Luke.Leber β
authored 8dafa34d on 1.0.x
- Status changed to Fixed
over 1 year ago 11:08pm 20 November 2023 - πΊπΈUnited States luke.leber Pennsylvania
I think that the deeper issues with SVG's might be an inherent bug in the PHP product itself:
Warning: DOMDocument::loadHTML(): Tag svg invalid in Entity, line: 1 in Caxy\HtmlDiff\ListDiffLines->listByLines() (line 91 of /var/www/html/vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/ListDiffLines.php).
I doubt the upstream library will fix something that's broken by
\DOMDocument
proper, but the least we can do is prevent the markup from being mangled in this case.Committed and pushed #6 to 1.0.x -- thanks!
- π·πΈSerbia miksha
Thanks. Interesting read on the topic https://foxpa.ws/domdocument-loadhtml-tags-invalid-parsing-html5-and-more
Automatically closed - issue fixed for 2 weeks with no activity.