- Issue created by @niklp
- last update
about 1 year ago 550 pass, 4 fail - last update
about 1 year ago 551 pass, 2 fail - last update
about 1 year ago 558 pass - Status changed to Needs review
about 1 year ago 6:12pm 17 November 2023 - 🇬🇧United Kingdom niklp Nottingham
Passes all rector checks to "functionally" run payment in D10 - further updates required for test modules etc.
- last update
about 1 year ago 556 pass, 1 fail - 🇨🇭Switzerland berdir Switzerland
> Passes all rector checks to "functionally" run payment in D10 - further updates required for test modules etc.
Quite confused by this.
Every single change you do in the MR is to tests and it's just two things as far as I see. the public/protected change which is correct but not technically required to make tests pass and the mock changes, which I'm confused about, looks like just a simplification.
Also, the gitlab-ci.yml is misnamed, it's missing the leading, so it doesn't actually run. I added a 10.1 test run now with DrupalCI, currently there are only 2 fails there: https://www.drupal.org/pift-ci-job/2808234 →
- last update
about 1 year ago PHPLint Failed - last update
about 1 year ago 558 pass - 🇬🇧United Kingdom niklp Nottingham
Sorry. Not massively au fait with the whole "new" drupal contribution setup, it's been a while.
What we were trying to do is make a version of the module available that would pass (most?) rector tests. I think we have these in our testing pipeline and need (a certain number of?) them to pass. What I did here was run rector across the module and basically commit the diff, with a few manual tweaks. This was last week so memory already fading.
Corrected the errors and what-not as suggested.