Fix the issues reported by eslint

/builds/issue/geofield-3402400/web/modules/custom/geofield-3402400/js/geolocation.js 7:2 warning Unexpected unnamed function func-names 7:10 error Replace `(geolocation,·$)` with `·(geolocation,·$)·` prettier/prettier 12:17 error Unexpected chained assignment no-multi-assign 13:36 warning Unexpected unnamed function func-names 13:44 error Replace `(callback){⏎` with `·(callback)·{` prettier/prettier 17:42 error Replace `function(){⏎` with `·function·()·{` prettier/prettier 17:42 warning Unexpected unnamed function func-names 20:15 error Delete `·` prettier/prettier 21:11 error Replace `"latitude"` with `latitude` prettier/prettier 21:23 error 'google' is not defined no-undef 22:11 error Replace `"longitude":·google.loader.ClientLocation.longitude` with `longitude:·google.loader.ClientLocation.longitude,` prettier/prettier 22:24 error 'google' is not defined no-undef 23:10 error Insert `,` prettier/prettier 27:8 error Delete `⏎` prettier/prettier 31:62 error Delete `⏎` prettier/prettier 35:2 warning Unexpected unnamed function func-names 37:5 warning Unexpected unnamed method 'attach' func-names 37:5 error Expected method shorthand object-shorthand 37:32 warning 'settings' is defined but never used no-unused-vars 42:15 error Replace `.find('.auto-geocode·.geofield-lat')` with `⏎··········.find('.auto-geocode·.geofield-lat')⏎··········` prettier/prettier 43:15 error Replace `.find('.auto-geocode·.geofield-lon')` with `⏎··········.find('.auto-geocode·.geofield-lon')⏎··········` prettier/prettier 50:9 error 'latitudeInput' was used before it was defined no-use-before-define 51:9 error 'longitudeInput' was used before it was defined no-use-before-define 52:9 error 'latitudeSpan' was used before it was defined no-use-before-define 53:9 error 'longitudeSpan' was used before it was defined no-use-before-define 58:28 error Replace `"#edit-instance"` with `'#edit-instance'` prettier/prettier 59:13 error 'fields' is never reassigned. Use 'const' instead prefer-const 59:13 error 'fields' is already declared in the upper scope on line 38 column 11 no-shadow 62:13 error Replace `fields.find('.auto-geocode·.geofield-lat').val()·===·''·&&·fields.find('.auto-geocode·.geofield-lon').val()·===·''` with `⏎··········fields.find('.auto-geocode·.geofield-lat').val()·===·''·&&⏎··········fields.find('.auto-geocode·.geofield-lon').val()·===·''⏎········` prettier/prettier 66:12 error Delete `⏎·········` prettier/prettier 68:13 warning Unexpected console statement no-console 74:12 error Replace `'geofield_geolocation',·'[name="geofield-html5-geocode-button"]'` with `⏎········'geofield_geolocation',⏎········'[name="geofield-html5-geocode-button"]',⏎······` prettier/prettier 74:86 warning Unexpected unnamed function func-names 75:20 warning Unexpected unnamed function func-names 75:28 error Insert `·` prettier/prettier 75:29 error 'e' is already declared in the upper scope on line 74 column 96 no-shadow 80:12 error Delete `⏎·········` prettier/prettier 82:13 warning Unexpected console statement no-console 87:7 error Split 'let' declarations into multiple statements one-var 87:25 error Replace `·longitudeInput,·latitudeSpan,` with `⏎········longitudeInput,⏎········latitudeSpan,⏎·······` prettier/prettier 90:72 error Insert `⏎········` prettier/prettier 90:72 warning Unexpected unnamed function func-names 91:1 error Insert `··` prettier/prettier 92:9 error Insert `··` prettier/prettier 93:1 error Replace `········` with `··········` prettier/prettier 94:1 error Insert `··` prettier/prettier 95:9 error Insert `··` prettier/prettier 96:1 error Replace `··········` with `············` prettier/prettier 97:9 error Replace `}⏎·······` with `··}` prettier/prettier 99:1 error Insert `··` prettier/prettier 99:11 warning Unexpected console statement no-console 100:1 error Insert `··` prettier/prettier 101:7 error Replace `}` with `··},⏎······` prettier/prettier 102:6 error Insert `,` prettier/prettier 103:4 error Replace `⏎` with `;` prettier/prettier

Comments & Activities

Issue created by @zniki.ru
Comment 7 months ago →
🇮🇹Italy itamair
Merge request !23Issue #3402431: fix eslint → (Merged) created by zniki.ru
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
18:14
17:11
Running
Status changed to Needs review 7 months ago2:03am 20 November 2023
Comment 7 months ago →
🇷🇺Russia zniki.ru
Created MR. Please make a review.
Comment 7 months ago →
🇮🇹Italy itamair
Why in this MR there are also included the following files:

.gitlab-ci.yml

geofield.services.yml

geofield.migrate_drupal.yml

They don't look related to the eslinting issues ...
Comment 7 months ago →
🇷🇺Russia zniki.ru
@itamait, thanks for your question.
I include .gitlab-ci.yml to run pipelines in Gitlab CI to verify that all issues fixed.

And eslint check runs only for .js, .yml files.

core/node_modules/.bin/eslint --no-error-on-unmatched-pattern --ignore-pattern="*.es6.js" --resolve-plugins-relative-to=core --ext=.js,.yml
Pipeline: https://git.drupalcode.org/issue/geofield-3402400/-/jobs/354770

That's why changes to files .yml were made.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
last update 7 months ago
26 pass
Status changed to RTBC 7 months ago10:21pm 24 November 2023
Comment 7 months ago →
🇮🇹Italy itamair
I also tested this on, with the new .gitlab-ci integration, and all LGTM.
Let's merge into origin/8.x-1.x ...
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
last update 7 months ago
26 pass
Comment 7 months ago →
System Message

itamair → committed 4b2ed7af on 8.x-1.x authored by zniki.ru →
Issue #3402431 by zniki.ru: Fix the issues reported by eslint
Status changed to Fixed 7 months ago10:22pm 24 November 2023
Comment 7 months ago →
🇮🇹Italy itamair
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by eslint

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!23Fix the issues reported by eslint
Merged

Comments & Activities

Fix the issues reported by eslint

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!23Fix the issues reported by eslintMerged

Comments & Activities

!23Fix the issues reported by eslint
Merged