Drupal 10 Compatibility

HI @jon.lund
I have added a patch, please review
Thanks

@viren18febS when you create pathces for new Drupal versions, you also should pay attention composer.json files, as they may have a the "drupal/core" key in the "require" section. For more details see:
1. https://www.drupal.org/project/project_composer/issues/3084063 →
2. https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →

Also, I get the error messages in Chrome console:

drupal.js?v=10.0.1:64 Uncaught TypeError: Cannot read properties of undefined (reading 'close')
    at Object.attach (dialog.ajax.js?v=10.0.1:45:45)
    at drupal.js?v=10.0.1:166:24
    at Array.forEach (<anonymous>)
    at Drupal.attachBehaviors (drupal.js?v=10.0.1:162:34)
    at success (ajax.js?v=10.0.1:1735:20)
    at l (loadjs.min.js?v=4.2.0:1:217)
    at loadjs.min.js?v=4.2.0:1:1556
    at Array.n (loadjs.min.js?v=4.2.0:1:1483)
    at o (loadjs.min.js?v=4.2.0:1:117)
    at loadjs.min.js?v=4.2.0:1:1287

I have updated the .json file & added a new patch file, please review.

@viren18febS what Drupal version do you use and do you see error messages in Chrome console?

This patch is exactly what is needed. Thank you.

It does need to be rolled into a new version so that that an update can be preformed prior to a Drupal 10 upgrade from Drupal ^9.5 as the upgrade fails due to incompatibility. This will help anyone else in need.

@jon.lund, what Drupal version do you use and do you see error messages in Chrome console (after you cleared the browser's caches)?

With the patch installed, using Drupal 10.1.6 and all drupal caches cleared and all browser caches cleared. I have no errors in the Chrome console.

Thank you for your work.

By the way, the same patch was created in #3286704 📌 Automated Drupal 10 compatibility fixes Fixed in 2022.

I knew that and that is why I tagged it in the original post.

The real issue is that it needs to be rolled into the module.

With it not in the module it keeps one from upgrading from Drupal ^9.5 to Drupal 10.

If you remove the module in order to upgrade to Drupal 10 and then add it back manually and apply the patch it will function. However when you use composer to update other modules it fails due to the conflict with this module requiring Drupal 9.

In order to circumvent this issue. This module had to be moved with the patch to a custom module vs. a contrib module so that it is left out of the composer update. When the patch has been rolled into the module and is then compatible it will be able to be moved back into contrib.

This also requires re-enabling the block where ever it was used. A fair bit of work. (Worth it due to it's usefulness)

As stated previously, it would be much appreciated if the patch were rolled into the module.

Thank you again for all that you do.

@jon.lund, I want to create a new release, but it still doesn't work on my system (Drupal 10.1.6, theme Olivero ) and I see errors in the console. I'll try to reinstall Drupal and test again. What theme do you use?

I am using a custom theme using the Stable9 starterkit, it is a Tailwindcss base theme.
I would be happy to do some testing with Olivero and Claro tomorrow. I will also look through your errors to see if I can discern anything.

I do see that you are having an issue with loading loadjs.min.js (as a side note upgrading to Drupal 10 caused an issue with IMCE module and it's js which is still unresolved for me. It is only happening when using aggrigation. If I turn off aggrigation everything works fine. This something that needs resolved.) Perhaps you are experiancing a similar issue.

I fixed the issue and created a new release.

Thank you!