Contrib.social

AudioFieldPluginBase requires concrete class rather than interface for URL

Open on Drupal.org →
Created on 16 November 2023, over 1 year ago

Similiar to this issue: https://www.drupal.org/project/audiofield/issues/3199946 →

But when you're using a CDN, which generates CDN-based URLs for files, the module breaks with this error:

TypeError: Drupal\audiofield\AudioFieldPluginBase::__construct(): Argument #8 ($file_url_generator) must be of type Drupal\Core\File\FileUrlGenerator, Drupal\cdn\File\FileUrlGenerator given, called in /path/to/web/modules/contrib/audiofield/src/AudioFieldPluginBase.php on line 90 in Drupal\audiofield\AudioFieldPluginBase->__construct() (line 68 of /path/to/web/modules/contrib/audiofield/src/AudioFieldPluginBase.php)

🐛 Bug report
Status

Active

Version

1.13

Component

Code

Created by

🇺🇸United States jason_purdy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jason_purdy
  • Comment over 1 year ago →
    🇪🇸Spain enchufe Spain

    As a workaround I've created a patch to make the AudioFieldPluginBase and WavesurferAudioPlayer classes support both DrupalCoreFileUrlGenerator and DrupalCoreFileUrlGenerator. And, as this patch fixes a problem that only affects in a specific scenario, I have added the CDN module as a dependency.

  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    🇩🇪Germany mfrosch

    Patch works for me.
    Also using a CDN.

  • Comment about 2 months ago →
    🇺🇸United States robertmartin1961

    The patch does resolve the issue, but the module has yet to be updated with the fix. I am currently using version 1.13.0 of the AudioField module, but I need to apply this patch whenever I reinstall the module. The only section of this patch that succeeds and fixes the issue is "/src/Plugin/AudioPlayer/WavesurferAudioPlayer.php"

    Who and when will this module be updated with the identified fix?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024