PHP 8 issue with entity_embed_field_info_formatter_settings

Created on 15 November 2023, over 1 year ago

Updated 3 April 2024, about 1 year ago

Problem/Motivation

Presently, entity_embed_field_info_formatter_settings() sometimes generates Optional parameter $settings declared before required parameter $form_state is implicitly treated as a required parameter in require_once() due to its function signature placing an optional parameter before required parameters which is deprecated as of PHP 8.0.0.

Steps to reproduce

Load entity_embed on a site using PHP 8+

Proposed resolution

Potentially drop declaration of settings parameter as optional, since all usages of it seem to supply the parameter.

API changes

Change $settings to required parameter?

🐛 Bug report

Status

Closed: outdated

Version

3.0

Component

Code

Created by

tadean

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @tadean
Comment over 1 year ago →
tadean
Added potential patch.
Status changed to Needs review over 1 year ago7:04pm 15 November 2023
Open on Drupal.org →
Core: 7.x + Environment: PHP 5.3 & MySQL 5.5
last update over 1 year ago
Waiting for branch to pass
Comment over 1 year ago →
tadean
Status changed to Closed: outdated about 1 year ago6:53am 3 April 2024
Comment about 1 year ago →
🇨🇦Canada devin carlson Sudbury, ON
Thanks for the patch!

This was fixed as part of adding alt + title support to display formatters.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024