Improve permissions to access the glossary overview page/ edit glossaries entries

Created on 14 November 2023, 8 months ago
Updated 27 November 2023, 7 months ago

Problem/Motivation

In order to enable editors to add, edit and delete glossary entries, it seems like not only the appropriate permissions are needed, but also the Administer DeepL glossary entities, otherwise they don't see the menu item. We might want to change this, so editors are able to edit glossary entries while not being permitted to edit the glossary entity itself.

Comment by @mrshowerman in #3232134 Allow use of glossaries for translations Fixed

Proposed resolution

  • users having one of the following permissions should be able to access the glossary overview page
    • add deepl_glossary entities
    • edit deepl_glossary entities
    • delete deepl_glossary entities
  • a new permission edit glossary entries is available, which allow users to edit the entries, but not other glossary information like name, source language, target language

Remaining tasks

  • update existing permission handling to allow users access to glossary overview page
  • add new permission edit glossary entries and update permission handling
Feature request
Status

Fixed

Version

2.2

Component

tmgmt_deepl_glossary

Created by

🇩🇪Germany SteffenR Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @SteffenR
  • 🇩🇪Germany SteffenR Germany
  • 🇩🇪Germany SteffenR Germany
  • 🇩🇪Germany SteffenR Germany
  • 🇩🇪Germany SteffenR Germany
  • 🇩🇪Germany SteffenR Germany
  • 🇩🇪Germany mrshowerman Munich

    Excellent, that's exactly what I need 👏🏼

  • Assigned to SteffenR
  • 🇩🇪Germany SteffenR Germany
    • SteffenR committed 9b10b10a on 2.2.x
      #3401614: Improve permission to access deepl_glossary overview/ edit...
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • 🇩🇪Germany SteffenR Germany

    @mrshowerman
    The changes can be tested in the latest 2.2.x-dev release of the module.

    I've also added a new permission access deepl_glossary overview to simplify access handling.
    Two hook_update_n take care of updating existing user roles with the new permissions.
    Feel free to test and give feedback.

  • Status changed to Needs work 7 months ago
  • 🇩🇪Germany mrshowerman Munich

    Not sure if this is a bug or a misunderstanding on my side, but I had to grant the "administer deepl_glossary entities" permission along with "access deepl_glossary overview" and "edit deepl_glossary glossary entries" in order enable editors to access and edit glossary entries.
    While editors aren't able to edit the glossary entities (which is good), I had expected that only the last two permissions would suffice, and the "administer" term sounds more powerful than what I wanted to grant them 😉

  • 🇩🇪Germany SteffenR Germany

    I'll have a further look.
    I my testing it was sufficient to just set access deepl_glossary overview and edit deepl_glossary glossary entries..

  • 🇩🇪Germany SteffenR Germany

    @mrshowerman
    Are you sure, that your permissions are configured correctly?

    I just did a test on a blank D10 site with just tmgmt and tmgt_deepl installed and got access to the deepl_glossary overview page without the need of the administer permission.

    The following permissions are granted to the role content_editor

      - 'access administration pages'
      - 'access content overview'
      - 'access contextual links'
      - 'access deepl_glossary overview'
      - 'access files overview'
      - 'access toolbar'
      - 'access tour'
      - 'administer url aliases'
      - 'create article content'
      - 'create page content'
      - 'create terms in tags'
      - 'create translation jobs'
      - 'create url aliases'
      - 'delete article revisions'
      - 'delete own article content'
      - 'delete own page content'
      - 'delete page revisions'
      - 'edit deepl_glossary glossary entries'
      - 'edit own article content'
      - 'edit own comments'
      - 'edit own page content'
      - 'edit terms in tags'
      - 'revert all revisions'
      - 'view all revisions'
      - 'view own unpublished content'
      - 'view the administration theme'
    
  • Status changed to RTBC 7 months ago
  • 🇩🇪Germany mrshowerman Munich

    I installed the module on another site, and there the "access overview " and "edit entries" permissions were sufficient. So it must be a different issue on the first site, will have to find out myself.

    Sorry for the noise, I think this is ready.

  • Status changed to Fixed 7 months ago
  • 🇩🇪Germany SteffenR Germany

    Thanks for testing the new functionality.
    A new 2.2.0 release was just released.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024