- Issue created by @viren18febS
- Status changed to Needs review
about 1 year ago 11:30am 14 November 2023 - 🇮🇳India viren18febS
I have fixed the issues and added a patch. please review
- Issue was unassigned.
- 🇮🇳India shalini_jha
hi @gisle
I have tested the patch and it's working fine for me.
I am able to log in after enabling this module with this patch. - 🇳🇴Norway gisle Norway
The patch works, put it is still not correct.
The statement:
$request->request->has('destination')
returns a boolean value (i.e.
true
orfalse
). The patch tests whether this is value is!empty
(which in PHP happens to be equivalent totrue
). However, doing so obfuscates the logic. We just want to check if this boolean value istrue
.I've created a MR with the correct logic.
- @gisle opened merge request.
- Status changed to Fixed
about 1 year ago 2:23pm 14 November 2023