Before making a release let's take one last pass to clean up the module state and config settings.
One thing I noticed is a difference between client_id and secret_id, we should make secret_id be client_secret I think.
We should also add a "last synced" timestamp state for the various importers. The cron job can use this same state to limit how frequently these things are checked.
Also, need to make sure we clean up this state on module uninstall. @m.stenta just shared an example:
/**
* Implements hook_uninstall().
*/
function mymodule_uninstall() {
// Delete all "mymodule.*" state values.
foreach (\Drupal::keyValue('state')->getAll() as $key => $value) {
if (strpos($key, 'mymodule') === 0) {
\Drupal::state()->delete($key);
}
}
}
N/A
Implement
None
None
None
Fixed
1.0
Code
Fixed. I also cleaned up some of the module config, there were inconsistencies between how we used config and state.
Automatically closed - issue fixed for 2 weeks with no activity.