Advanced form button styling

It looks nice with Gin!

Not really sure best approach here given variety of admin themes. Could potentially attach a library conditional of the claro theme with a small CSS tweak

Have:

• Added outer wrapper div with text-align: right
• Removed float and bottom margin from the button

Visually the change looks good to me, tested on Claro and Gin and looks good. Couple minor points. Would be good to spin up MR to use the gitlab pipeline code style checks / tests.

+++ b/js/advanced-form.js
@@ -1,15 +1,16 @@
+(function ($, window, Drupal) {

Is this change related, can't see where window is used?

+++ b/js/advanced-form.js
@@ -1,15 +1,16 @@
+      var toggleButton = "<div class='advanced-form-ow'><button class='advanced-form-toggle btn' type='button' title='Some form elements may be hidden. Switch this form between full and partial detail'>Switch to Advanced</button></div>";

Should the class be `.advanced-form-row`?

Outer wrapper :) I changed to just wrapper - and took out other misc changes

Looks good to me! I note that eslint is showing an additional error for using var, but its already showing a lot of errors in on the main branch and I think its better to be consistent with the rest of the file.

Better late than never! Not sure why I didn't merge this at the time - have been using the patch for over a year.

Automatically closed - issue fixed for 2 weeks with no activity.