- Issue created by @wotnak
- 🇦🇺Australia darvanen Sydney, Australia
Also this line 165 in AssetLibrary.php now fails because vite returns a 200 instead of 404:
return $this->httpClient->request('GET', $this->getDevServerBaseUrl(), ['http_errors' => FALSE])->getStatusCode() === 404;
- Status changed to Needs review
12 months ago 2:39am 22 November 2023 - 🇦🇺Australia darvanen Sydney, Australia
I note the manifest.json location work is already in 1.x-dev so I think this is all that's left for Vite 5 compatibility?
- Status changed to Needs work
12 months ago 5:38am 22 November 2023 - 🇵🇱Poland wotnak
Change looks good. The only thing to fix is one issue reported by phpstan (you can see it in the merge request ui).
The in_array function should be called with the third parameter set to true to strictly compare values, including checking their types. https://www.php.net/manual/en/function.in-array.php#refsect1-function.in... - First commit to issue fork.
- Status changed to Fixed
12 months ago 7:35am 22 November 2023 -
wotnak →
committed 32a394ed on 1.x authored by
darvanen →
Issue #3401054 by darvanen, ankithashetty: Vite 5 compatibility
-
wotnak →
committed 32a394ed on 1.x authored by
darvanen →
- 🇦🇺Australia darvanen Sydney, Australia
Many thanks for tidying that up and the swift release :)
Automatically closed - issue fixed for 2 weeks with no activity.