- Issue created by @lkacenja
- 🇺🇸United States lkacenja
Removing the `#error_no_message` from the number input and then removing the no longer necessary Price::moveInlineErrors method seems to fix the issue for me. See https://git.drupalcode.org/issue/commerce-3400651/-/tree/3400651-inline-...
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
8 months ago Not currently mergeable. - @lkacenja opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Status changed to Needs review
8 months ago 4:43pm 14 November 2023 - 🇺🇸United States lkacenja
We deployed a patch with the contents of this MR to our development environment and ran it through automated tests. Everything seems good to us. Moving this to needs review.
- 🇺🇸United States rymcveigh
I reviewed these changes, and they look good to me. The failing unit tests are the same as the failing unit tests on the current release of this module. Do we need to add unit tests for inline errors as part of these adjustments? Or are there tests already in place?
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
7 months ago Waiting for branch to pass -
jsacksick →
committed 6eee654f on 3.0.x authored by
lkacenja →
Issue #3400651 by lkacenja Inline errors on price field are not visible.
-
jsacksick →
committed 6eee654f on 3.0.x authored by
lkacenja →
-
jsacksick →
committed df0f2803 on 8.x-2.x authored by
lkacenja →
Issue #3400651 by lkacenja Inline errors on price field are not visible.
-
jsacksick →
committed df0f2803 on 8.x-2.x authored by
lkacenja →
- Status changed to Fixed
7 months ago 8:38am 17 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.