- Issue created by @kevinquillen
- First commit to issue fork.
- Assigned to scott_euser
- Status changed to Needs work
about 1 year ago 7:41am 10 November 2023 - π¬π§United Kingdom scott_euser
Actually seems like there is quite a lot to do here - I have refactored the config storage to follow Core's book/image_style mapping and handling saving in the VectorClientPluginBase so heavy lifting there does not need to be duplicated per Plugin (though Plugins can of course override the Base methods).
There is a fair bit of duplication though in PineconeClient that now does not work (eg, the SearchForm) as I have not updated these to use the Plugin's configuration. I believe that PineconeClient should be removed in favour of the Pinecone plugin, and so actually next steps would be for me to check each place PineconeClient is used and move it to using the Plugin instead. Do you agree? If so I'll action that + I can update the scope of the summary of this card. I think we cannot move to a separate task as this is not mergeable as is given all it breaks, so unfortunately its going to end up being a slightly bigger merge request.
- πΊπΈUnited States kevinquillen
Yeah - that was the idea (removing PineconeClient). I had hit a blocker and don't recall what it was at the time. But the calls and logic in PineconeClient would be copied into Pinecone.php (its a little outdated) and everything routes through the plugin(s).
It seems like they should at a minimum, support/implement:
- - Configuration storage
- - "Test" form definition, the barebones search UI to quickly check your integration/data (like whats there now)
- - "Status"/index stats tab, where it lists collections data if supported
- - General methods (CRUD?) required for working with embedding related data
- π¬π§United Kingdom scott_euser
Sounds good, thanks! I will try to progress on it the upcoming days a bit.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:10pm 10 November 2023 - π¬π§United Kingdom scott_euser
Probably we'll need a bunch of follow-ups, particularly once we add other vector clients, I think then the differences will become clear and the interface can updated then to match?
I did a full test run from index, settings configuration, search, and stats, the only bit that did not work was the delete but that is a problem from the Pinecone starter as you noted in the description in the delete form (possibly can be a follow-up as maybe Delete All will work, which is anyways what the Delete form is doing)
-
scott_euser β
committed a2153ee2 on 1.0.x
Issue #3400627 by scott_euser: Finish VectorClient plugin code
-
scott_euser β
committed a2153ee2 on 1.0.x
- Status changed to Fixed
about 1 year ago 6:53am 18 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.