Exception thrown on Unpublish On Empty process plugin

This conversation shows the history of this change.

https://git.drupalcode.org/project/orange_dam/-/merge_requests/43#note_2...

trim() requires a string, but $row->get(configuration['field']) returns a field

What is a "field"? I'm trying to work on a fix, but genuinely unsure what the code change should be to prevent the issue.

I've pushed up a fix. The gist is simply that we can't always assume the field value will be a string. We could either limit the plugin to strings only and handle the exception with a MigrateException or we could increase the utility of the plugin. My fix is to increase the utility of the plugin.

I am testing this change with string values, arrays, and objects. Looks good to me.

>Could we add some comments explaining why we need all of this logic? Otherwise this looks good.

Good call and I think the annotation covers it pretty well.

Automatically closed - issue fixed for 2 weeks with no activity.