Providing a version that's compatible with D10 and Group 1.x

Yup, I’m in favor. Most of the code is probably done in the original D10 porting issue. But it’d be easier to do it in a new patch / MR here.

That said, I’m completely slammed the next few weeks, so it’ll be December at the earliest before I could work on this myself.

This was much simpler than anticipated. Here is what I've done:

• Created issue fork based on 1.0.x-dev
• Updated composer.json and info file
• Run PHPStan and go through all the findings
• Each finding was then compared to the latest 2.0.x-dev branch and it turned out, that none of those instances got updated in the 2.x branch either, so they were left as-is in 1.x as well

So, this is all that was necessary to get it compatible with D10 and G1.

Cool, thanks. However, that's insufficient for at least passing tests on D10. Trying to run the tests locally against a 10.1.x core dev site, and I'm getting:

Testing /.../entitygroupfield
ESEE                                                                4 / 4 (100%)

Time: 00:12.518, Memory: 10.00 MB

There were 3 errors:

1) Drupal\Tests\entitygroupfield\Functional\EntityGroupFieldFormatterTest::testFieldFormatters
Error: Call to undefined method Drupal\Tests\entitygroupfield\Functional\EntityGroupFieldFormatterTest::assertNoText()

/.../entitygroupfield/tests/src/Functional/EntityGroupFieldFormatterTest.php:83
/.../vendor/phpunit/phpunit/src/Framework/TestResult.php:728

2) Drupal\Tests\entitygroupfield\Kernel\GroupAutocompleteFormElementTest::testGroupAutocompleteNoGroups
LogicException: system module does not define a schema for table 'key_value_expire'.

/.../core/tests/Drupal/KernelTests/KernelTestBase.php:764
/.../entitygroupfield/tests/src/Kernel/EntityGroupFieldKernelTestBase.php:44
/.../entitygroupfield/tests/src/Kernel/GroupAutocompleteFormElementTest.php:34
/.../vendor/phpunit/phpunit/src/Framework/TestResult.php:728

3) Drupal\Tests\entitygroupfield\Kernel\GroupAutocompleteFormElementTest::testGroupAutocomplete
LogicException: system module does not define a schema for table 'key_value_expire'.

/.../core/tests/Drupal/KernelTests/KernelTestBase.php:764
/.../entitygroupfield/tests/src/Kernel/EntityGroupFieldKernelTestBase.php:44
/.../entitygroupfield/tests/src/Kernel/GroupAutocompleteFormElementTest.php:34
/.../vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 4, Assertions: 12, Errors: 3, Skipped: 1.

These should be fairly easy fixes. Again, see the original automated D10 porting issue for more. I think I determined we can safely remove the key_value_expire schema from the Kernel tests, even in 8.9.x core, but I'm forgetting the details, and don't have time to fully solve this right now.

Thanks again!
-Derek

p.s. We also need to tweak the .gitlab-ci.yml file in the 8.x-1.x branch to get this testing on D10. Not sure if we need the full complications of the 2.0.x branch's copy with the "matrix" testing, or if there's a slicker way to have it test on D10 by default but still be able to test earlier versions, etc.

Heh, I kept referencing the original issue, but forgot it was still open. 😅 Let's continue there. This is mostly already done over there.

dww → closed merge request !12