Contrib.social

Use hook to set data-src

Open on Drupal.org →
Created on 8 November 2023, over 1 year ago

Problem/Motivation

Currently the loading is denied because the script sets src to data-src.
Under some circumstances the video still loads, because the script is too slow. I can not reproduce this in a solid way, it just happens sometimes.

Steps to reproduce

Proposed resolution

Use theme_preprocess_media_oembed_iframe to modify the iframe. Then it is independent from js.
Use the js to set the dara-src to src.

This is also mentioned on the scripts github page (german):
https://github.com/a-v-l/dsgvo-video-embed

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.1

Component

Code

Created by

🇩🇪Germany marcoka

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @marcoka
  • Comment over 1 year ago →
    🇩🇪Germany marcoka
  • Comment over 1 year ago →
    🇩🇪Germany marcoka
  • Comment over 1 year ago →
    🇩🇪Germany marcoka

    Just wanted to say that i forked/hacked the module:

    It now uses the local oembed thumbnail as a background image for the video. Tested with youtube.
    That means absolutely ZERO cookies are set and it is DSGVO/GDPR compatible.
    It also speeds up pageload and declutters the html code because the inner iframe code (huge html chunk) is ONLY loaded if the user clicks ok.

    I can upload it here i a bit. I have not created any patches yet because i changed a lot of the js code and added some hooks.

  • Comment 12 days ago →
    🇩🇪Germany vistree

    Hi @marcoka,
    can you provide your module version? I already updated the module to Drupal 10 and want now to get the YouTube placeholder image on media upload (good resolution) and use that as a background image ...

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024