- Issue created by @mstrelan
- @mstrelan opened merge request.
- Status changed to Needs review
about 1 year ago 11:54pm 5 November 2023 - Status changed to RTBC
about 1 year ago 1:54am 6 November 2023 - 🇺🇸United States dww
This looks good, thanks. Happy to see all this boilerplate noise go. 🎉 And it makes life easier for 📌 Add declare(strict_types=1) to all tests Needs work and friends. Let's get this in.
Thanks again,
-Derek - 🇺🇸United States xjm
Weird, how did these escape the 8.1.x purge?
Confirmed there were no outstanding cases of
@file
docblocks for tests once the patch was applied. Also reviewed the whole MR and confirmed that all the removed docblocks were 100% redundant boilerplate, with no meaningful documentation that should go in the class docblock.Committed to 11.x and 10.2.x, and backported to 10.1.x as a patch-safe docs coding standard fix. Thanks!
Should we add a followup for a coding standards check to validate that classes, interfaces, and traits never contain an
@file
annotation? - Status changed to Fixed
about 1 year ago 9:38pm 10 November 2023 - 🇦🇺Australia mstrelan
I think we can use the ForbiddenAnnotations sniff. Would have been good if I found this earlier instead of using php-cs-fixer. Will open an issue next week.
- 🇬🇧United Kingdom longwave UK
Opened 📌 Prevent @file annotations from creeping back into the codebase Active
Automatically closed - issue fixed for 2 weeks with no activity.