Loading indicator no longer working

Created on 5 November 2023, 7 months ago
Updated 10 November 2023, 7 months ago

Problem/Motivation

The loading indicator animation does not work anymore.

The blue rectangle is present, but the animation stopped by following commit:
Commit 6d48b2cf

No loading indicator at all by following commit:
Commit 8ceb1978

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany Corn696 Flensburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Corn696
  • 🇮🇩Indonesia gausarts

    Thank you.

    You are correct.

    Looks like is-b-visible class no longer kicks in.

    AFAIK, the regression happened when there was a feature request to make both Blur and Loading indicator work together.

    You know, fixing one breaks other things as usual :) Both Blur and Loading indicator operate on the same selector. Last time, only one can work, later both are playing nice together, but forgot to keep old behavior.

    Temporary solution till we fix the JS stuffs:

    • Try enabling Add is-b-visible class ad Blazy UI.
  • 🇩🇪Germany Corn696 Flensburg

    Yep happens.

    Temporary solution till we fix the JS stuffs:

    • Try enabling Add is-b-visible class at Blazy UI.

    Thanks, already tried it. Does not work.
    But I will just temporarily revert the CSS changes for my site. Blur is not in use on our site.

  • Status changed to Needs review 7 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 7 months ago
    50 pass
  • 🇮🇩Indonesia gausarts

    Got it.

    Let me know if this works?

  • Status changed to RTBC 7 months ago
  • 🇩🇪Germany Corn696 Flensburg

    Seems to work without and with blur now thx :)

    • gausarts committed f9abd9fe on 8.x-2.x
      Issue #3399304 by gausarts, Corn696: Loading indicator no longer working
      
  • Status changed to Fixed 7 months ago
  • 🇮🇩Indonesia gausarts

    We should refine these Loading vs Blur animations later. Should do with the limited time for now.

    Thank you for contribution.

  • 🇺🇬Uganda Thomas Kaisuka

    Hello gausarts,

    Before i update, i noticed that without the loader animations, my websites have been loading much faster because i use the responsive image module.

    The cube animations tended to add more time on my cummulative layout shift time when using plugins like masonry as the js waited longer to load due to the animations from blazy.

    Let me test this update and see how it goes.

  • 🇺🇬Uganda Thomas Kaisuka

    Hello gausarts,

    I think it would be prudent to make us choose between the square animations and the blur effect (which works much better now),

    Currently the squares animations are back even without me selection the is-b-visible option.

    Like i mentioned earlier this impacts page loading time with a multi-image page in my situation.

    The two effects might need different js selectors as a future considerations to combat this

  • 🇮🇩Indonesia gausarts

    Agreed, as said in #7.

    Perhaps best is to add an option to negate Blur vs Loading indicator each other like before, along with combo option, only with user consents now.

    Patches are welcome, in another thread.
    Thank you.

  • 🇮🇩Indonesia gausarts

    ATM, for particular usage with massive images like yours, two flexible solutions exist:
    1. Implement hook_blazy_settings_alter, see blazy.api.php, to set blazies.use.loader to FALSE, like here:
    https://git.drupalcode.org/project/ajaxin/-/blob/8.x-1.5/ajaxin.module?r...
    2. Override blazy.loading.css, and set this to display: none:
    https://git.drupalcode.org/project/blazy/-/blob/8.x-2.22/css/components/...

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024