Fallback to anonymous user if no default user is set

Open on Drupal.org →

Created on 3 November 2023, about 1 year ago

Updated 6 November 2023, about 1 year ago

Problem/Motivation

\Drupal\simple_oauth\Grant\ClientCredentialsOverrideGrant::getDefaultUser returns null if there is no user, or if the `target_id` is `0`.

Can simple_oauth allow anonymous users as the default user?

    return $client_drupal_entity
      ? $client_drupal_entity->get('user_id')->target_id
      : NULL;

This check fails because of `0` and not an explicit `null` check

if (!$this->getDefaultUser($client)) {

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request

Status

Fixed

Version

5.2

Component

Code

Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @mglaman
Comment about 1 year ago →
🇺🇸United States mglaman WI, USA
I just realized we're on 5.2.3 and may not apply to 6.x
Comment about 1 year ago →
🇺🇸United States mglaman WI, USA
@mglaman opened merge request.

Comment about 1 year ago →

🇺🇸United States mglaman WI, USA

I don't think this is an issue for 6.x with \Drupal\simple_oauth\Repositories\ScopeRepository::finalizeScopes

    $default_user = NULL;
    if (!$client_entity->getDrupalEntity()->get('user_id')->isEmpty()) {
      $default_user = $client_entity->getDrupalEntity()->get('user_id')->entity;
    }

Comment about 1 year ago →
System Message

bojan_dev → committed 1a929833 on 5.2.x authored by mglaman →
Issue #3399091: only error if user is null
Status changed to Fixed about 1 year ago8:13pm 6 November 2023
Comment about 1 year ago →
🇳🇱Netherlands bojan_dev
TY @mglaman, for 6.0.x this is not applicable.
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024