Current module not Drupal 10 compatible

Created on 3 November 2023, 8 months ago
Updated 18 December 2023, 6 months ago

Problem/Motivation

I'm working on getting my website compatible for Drupal 10. This module says that its current version is D10 compatible, but it does not list 10 here: web/modules/contrib/phpmailer_smtp/phpmailer_smtp.info.yml

Steps to reproduce

Drupal.org's suggested composer command composer require 'drupal/phpmailer_smtp:^2.2' doesn't install the correct version.

What does work:

composer require 'drupal/phpmailer_smtp:^2.2.0'

Original report:

Download the Drupal Upgrade module. Find the report. This module will likely be listed as incompatible.

Proposed resolution

Change the info file to include Drupal 10. Make necessary code changes to be compatible with Drupal 10.

πŸ› Bug report
Status

Closed: cannot reproduce

Version

2.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rraney

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rraney
  • Status changed to Closed: works as designed 8 months ago
  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    This module says that its current version is D10 compatible, but it does not list 10 here:

    It sure does. https://git.drupalcode.org/project/phpmailer_smtp/-/blob/2.2.3/phpmailer...

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    OK sorry about that. I don't know what I was looking at. Perhaps it was a cached file.

  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    The Upgrade Status β†’ module can help.

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    Yes, thanks. It was showing this module as "Collaborate with maintainer" or whatever that is, and I don't remember exactly what happened over the weekend, but it's no longer there. All good - thanks.

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    Now I understand what my issue is. I updated the module using this command:
    composer require 'drupal/phpmailer_smtp:^2.2'

    While using Drupal Upgrade Status, it lists this module as incompatible. I attached a screenshot.

    Also, I cannot find this module in my list of Available updates /admin/reports/updates. It's listed as an installed module, but it's like Drupal doesn't know which version it has, so it's not including it.

  • Status changed to Active 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States rraney
  • πŸ‡ΊπŸ‡ΈUnited States rraney

    I updated this module but the .info file shows core_version_requirement: ^8.8 || ^9.

    If the code repository absolutely has the updated D10 in the code, then I have some sort of issue getting the most recent version. I will look around for your current codebase, but I definitely updated to the most recent version.

  • πŸ‡ΊπŸ‡ΈUnited States rraney
    limestonedouglas@limestone [~/test]# composer require 'drupal/phpmailer_smtp:^2.2'
    ./composer.json has been updated
    Running composer update drupal/phpmailer_smtp
    Gathering patches for root package.
    Loading composer repositories with package information
    Updating dependencies
    Nothing to modify in lock file
    Installing dependencies from lock file (including require-dev)
    Nothing to install, update or remove
    Package doctrine/reflection is abandoned, you should avoid using it. Use roave/better-reflection instead.
    Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead.
    Package symfony/debug is abandoned, you should avoid using it. Use symfony/error-handler instead.
    Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
    Generating autoload files
    60 packages you are using are looking for funding.
    Use the `composer fund` command to find out more!
    phpstan/extension-installer: Extensions installed
    No security vulnerability advisories found.
  • Status changed to Postponed: needs info 8 months ago
  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    That sounds a bit odd. Try removing it then adding it again using the commands below and let me know how you go.

    composer remove drupal/phpmailer_smtp

    composer require drupal/phpmailer_smtp:~2.2.0

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    Thank you - I'm not seeing it now in the "Collaborate with Maintainers" section.

    Admittedly, there is a lot of crazy stuff happening in my efforts to update modules for D10.

  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    OK thanks. You can do a manual scan of it with upgrade_status to get the all clear.

    I won't close this yet as Drupal.org's suggested composer command on the project page doesn't work as expected.

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    I ran a scan in Upgrade Status for this module. I'm getting this "problem", which is something I see with all of my custom modules.

    PHPStan command failed:
    /opt/alt/php81/usr/bin/php-cgi /home/limestonedouglas/test/vendor/bin/phpstan analyse --memory-limit=1500M --error-format=json --configuration=/tmp/upgrade_status/deprecation_testing.neon /home/limestonedouglas/test/web/modules/contrib/phpmailer_smtp
    
    Command output:
    X-Powered-By: PHP/8.1.24 Cache-Control: must-revalidate, no-cache, private Date: Mon, 13 Nov 2023 21:20:39 GMT Content-Type: application/json X-UA-Compatible: IE=edge Content-language: en X-Content-Type-Options: nosniff X-Frame-Options: SAMEORIGIN Expires: Sun, 19 Nov 1978 05:00:00 GMT X-Generator: Drupal 9 (https://www.drupal.org) {"status":true,"percentage":"100","message":"Completed 1 of 1.","label":"Analysis complete for phpmailer_smtp."}
    
    Command error:
    Empty.
  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    What happens when you do a scan via the reports page /admin/reports/upgrade-status?

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    Nothing really happened. It brought me back to the page that lists modules, etc. A log shows, "Finished Upgrade Status processing Successfully."

    PHPMailer SMTP (phpmailer_smtp)
    Contributed module
    Installed
    2.2.3 Compatible
    1 problem (already shared)
    Drupal.org version: Not applicable
    Drupal.org ready: Unchecked
    Drupal.org issues: Issues
    Plan: N/A

  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania

    This is what is showing on the reports page after I selected the checkbox next to "PHPMailer SMTP" and clicked "Scan selected".

    PHPMailer SMTP (phpmailer_smtp)
    Contributed module Installed 2.2.3 Compatible No problems found Up to date Compatible Issues N/A

  • πŸ‡ΊπŸ‡ΈUnited States rraney

    Okay, we have different results and I don't know why. It's in the "compatible" Drupal 10 area, but not recognized for the drupal.org fields.

  • Status changed to Closed: cannot reproduce 6 months ago
  • πŸ‡¦πŸ‡ΊAustralia imclean Tasmania
Production build 0.69.0 2024