Cannot apply rector patch for Drupal 10 compatibility

Created on 3 November 2023, 8 months ago

Problem/Motivation

I tried applying the automated rector patch, which presumably adds ^10 to the list of acceptable Drupal core versions. My syntax in the composer.json file matches syntax for other modules I've successfully patched in the same way.

"drupal/node_class": {
              "3288775: Drupal 10 compatibility - Rector patch": "https://www.drupal.org/files/issues/2022-06-16/node_class.2.0.x-dev.rector.patch"
          }

I ran composer -v install and got errors.

  - Applying patches for drupal/node_class
    https://www.drupal.org/files/issues/2022-06-16/node_class.2.0.x-dev.rector.patch (3288775: Drupal 10 compatibility - Rector patch)
patch '-p1' --no-backup-if-mismatch -d 'web/modules/contrib/node_class' < '/tmp/65450e77f2119.patch'
patching file node_class.info.yml

Hunk #1 FAILED at 1.

1 out of 1 hunk FAILED -- saving rejects to file node_class.info.yml.rej

patch '-p0' --no-backup-if-mismatch -d 'web/modules/contrib/node_class' < '/tmp/65450e77f2119.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/node_class.info.yml b/node_class.info.yml
|index 1e4e3b9..b392d8b 100644
|--- a/node_class.info.yml
|+++ b/node_class.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.

1 out of 1 hunk ignored

patch '-p2' --no-backup-if-mismatch -d 'web/modules/contrib/node_class' < '/tmp/65450e77f2119.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/node_class.info.yml b/node_class.info.yml
|index 1e4e3b9..b392d8b 100644
|--- a/node_class.info.yml
|+++ b/node_class.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.

1 out of 1 hunk ignored

patch '-p4' --no-backup-if-mismatch -d 'web/modules/contrib/node_class' < '/tmp/65450e77f2119.patch'
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/node_class.info.yml b/node_class.info.yml
|index 1e4e3b9..b392d8b 100644
|--- a/node_class.info.yml
|+++ b/node_class.info.yml
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.

1 out of 1 hunk ignored

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2022-06-16/node_class.2.0.x-dev.rector.patch

In Patches.php line 331:

  [Exception]
  Cannot apply patch 3288775: Drupal 10 compatibility - Rector patch (https://www.drupal.org/files/issues/2022-06-16/node_class.2.0.x-dev.rec
  tor.patch)!


Exception trace:
  at /home/limestonedouglas/test/vendor/cweagans/composer-patches/src/Patches.php:331
 cweagans\Composer\Patches->postInstall() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/EventDispatcher/EventDispatcher.php:206
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/EventDispatcher/EventDispatcher.php:148
 Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer/InstallationManager.php:396
 Composer\Installer\InstallationManager::Composer\Installer\{closure}() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer/InstallationManager.php:411
 Composer\Installer\InstallationManager->executeBatch() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer/InstallationManager.php:319
 Composer\Installer\InstallationManager->downloadAndExecuteBatch() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer/InstallationManager.php:218
 Composer\Installer\InstallationManager->execute() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer.php:804
 Composer\Installer->doInstall() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Installer.php:292
 Composer\Installer->run() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Command/InstallCommand.php:147
 Composer\Command\InstallCommand->execute() at phar:///home/limestonedouglas/.composer/composer.phar/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///home/limestonedouglas/.composer/composer.phar/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///home/limestonedouglas/.composer/composer.phar/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Console/Application.php:382
 Composer\Console\Application->doRun() at phar:///home/limestonedouglas/.composer/composer.phar/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///home/limestonedouglas/.composer/composer.phar/src/Composer/Console/Application.php:145
 Composer\Console\Application->run() at phar:///home/limestonedouglas/.composer/composer.phar/bin/composer:93
 require() at /home/limestonedouglas/.composer/composer.phar:29

install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]

At this time, I have not been able to make this module compatible with Drupal 10. I use this module heavily on our site and it greatly affects how many pages are rendered.

Steps to reproduce

Apply the automated patch shown above.

Proposed resolution

Either provide a working short-term patch or release a Drupal 10 compatible module.

πŸ’¬ Support request
Status

Active

Version

2.0

Component

Miscellaneous

Created by

πŸ‡ΊπŸ‡ΈUnited States rraney

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024