As part of
#2910410: Unable to add or edit order line item without overriding the unit price →
, some logic was added to UnitPriceWidget::extractFormValues() to detect the order the order item belongs to in order to calculate the unit price when it is not explicitly overridden in the widget. See changes.
With this logic, it firstly tries to get the order from the order item, and if it fails, it tries to retrieve it from the entity form, if only it is an instance of OrderForm.
Later, in a second iteration as part of #3137651: Error: Call to undefined method Drupal\commerce_order\Entity\OrderItem::getCustomer() → , this logic was changed in order to ensure that order was correctly loaded in order to calculate the price. See change.
However,trying to optimize the query, the situation ended up forcing to have an instance of OrderForm to make it work. It happens because the whole calculation process ignores the order declared by the order item, if any. See line 179 of the current code.
Our proposal is to adjust the logic to take into account the order defined by the order item, if any, and then fallback to the one defined by the form, and finally skip the process if the order is not set. That was the aim of #3137651: Error: Call to undefined method Drupal\commerce_order\Entity\OrderItem::getCustomer() → .
We found this issue while working on the Commerce Order Item UI → module, so the easiest way to reproduce this bug is installing that module:
Fixed
2.0
Order
Added more clear steps to reproduce the issue.
Would be great to have this issue reviewed because it is necessary for Commerce Order Item UI → module.
Thank you!
Automatically closed - issue fixed for 2 weeks with no activity.