Certain adblock filters block the plugin from loading

Created on 2 November 2023, about 1 year ago

Problem/Motivation

We encountered an issue where some of our site editors noted that CKEditor was not loading after an upgrade to CKEditor5. Their javascript logs showed that "Loading failed for the

with source “.../modules/contrib/insert_view_adv/js/build/insert_view_adv.js?v=9.5.11”. edit:592:84". After some digging, we found that the users with the issue were using adblockers. Further digging revealed that the  fr [ca]  ca: AdGuard Français blocklist (in AdGuard and Optionally in uBlock Origin, and likely in other adblockers) includes a rule for "_adv.js" which triggers for the plugin file. This issue did not occur in the CKEditor4/1.x version since CK4 plugins all used the filename "plugin.js"

Steps to reproduce

Enable the "AdGuard Français blocklist" in a blocker like uBlock origin and load a page with an editor with the "Advanced Insert View" plugin in the toolbar. The editor will fail to load.

Proposed resolution

Changing the plugin filename should resolve this.

Other Notes

While I don't think modules should necessarily need to adjust for adblockers, I do think it's worth noting that this issue could happen. Even if the solution is for editors to whitelist domains or disable their adblocker, I hope others can find this report to guide them to a solution. On the flip side, a simple change to the plugin filename would probably prevent this from happening.
🐛 Bug report
Status

Active

Version

2.0

Component

Miscellaneous

Created by

🇺🇸United States pkozik

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024