Contrib.social

Wrong variable name in validateClient after refactor

Open on Drupal.org →
Created on 2 November 2023, about 1 year ago

Problem/Motivation

During refactoring, the variable $client_secret in ClientRepository->validateClient was not renamed, afaik.

https://git.drupalcode.org/project/simple_oauth/-/blob/6.0.x/src/Reposit...

public function validateClient($clientIdentifier, $clientSecret, $grantType) {
...
if (!$client_drupal_entity->get('confidential')->value &&
      $secret_field->isEmpty() &&
      empty($client_secret) &&
      $grantType !== 'client_credentials') {
      return TRUE;
    }
...
}
🐛 Bug report
Status

Fixed

Version

6.0

Component

Code

Created by

🇧🇪Belgium ducktape

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024