- Issue created by @star-szr
- @star-szr opened merge request.
- Status changed to Needs review
about 1 year ago 11:39am 2 November 2023 - First commit to issue fork.
- Status changed to RTBC
about 1 year ago 11:41am 2 November 2023 - 🇪🇸Spain fjgarlin
Thanks so much for spotting and fixing that!! It's super straight forward, so committing shortly.
- 🇪🇸Spain fjgarlin
Don't worry about it. I also need to rebase before merging, so maybe that's what created the issue.
I will merge in a few minutes. Thanks! - Issue was unassigned.
- 🇨🇦Canada star-szr
Ah, nevermind it looks like maybe you merged in 1.0.x or something? Sorry about that, I will leave it alone 😬
-
fjgarlin →
committed c812683a on 1.0.x authored by
star-szr →
Issue #3398680 by star-szr, fjgarlin: Incorrect instructions for testing...
-
fjgarlin →
committed c812683a on 1.0.x authored by
star-szr →
- Status changed to Fixed
about 1 year ago 12:16pm 2 November 2023 -
fjgarlin →
committed c812683a on decoupled_pages authored by
star-szr →
Issue #3398680 by star-szr, fjgarlin: Incorrect instructions for testing...
-
fjgarlin →
committed c812683a on decoupled_pages authored by
star-szr →
- First commit to issue fork.
- 🇬🇧United Kingdom jonathan1055
Thanks for raising this issue. I had also noted the incorrect instructions. There are more improvements that I had noted, see new MR.
- Merge request !80Issue #3398680 Improve descriptions for testing against branch/MR → (Merged) created by jonathan1055
- Status changed to Needs review
about 1 year ago 4:08pm 3 November 2023 - 🇬🇧United Kingdom jonathan1055
MR80 ready for review. It is good to explicitly show the default in variables.yml description, as that helps developers to know what the original value would be if someone has overridden it.
In the README, it was confusing to have the defaults showing when the whole point of that instuction was to show how to test against a branch/mr. I also separated out the attributes from the KEY and VALUE pairs.
-
fjgarlin →
committed e92b5879 on 1.0.x authored by
jonathan1055 →
Issue #3398680 by fjgarlin, star-szr, jonathan1055: Incorrect...
-
fjgarlin →
committed e92b5879 on 1.0.x authored by
jonathan1055 →
- Status changed to Fixed
about 1 year ago 3:14pm 29 November 2023 - 🇪🇸Spain fjgarlin
Thanks for the MR and fixes. Mergin this as it improves the current readme.
- 🇬🇧United Kingdom jonathan1055
Thank also to @star-szr for fixing my spellong misteks.
Automatically closed - issue fixed for 2 weeks with no activity.