Contrib.social

Fix code quality issues reported by PHPStan

Open on Drupal.org →
Created on 2 November 2023, almost 2 years ago

Problem/Motivation

Currently there are some code errors reported in PHPStan CI job:

 ------ ---------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/EntityViewModeDeleteFormHelperTest.php  
 ------ ---------------------------------------------------------------- 
  136    No error to ignore is reported on line 136.                     
 ------ ---------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/Plugin/Field/FieldType/ViewModeSwitchItemListTest.php  
 ------ ------------------------------------------------------------------------ 
  159    No error to ignore is reported on line 159.                             
 ------ ------------------------------------------------------------------------ 
 ------ -------------------------------------------- 
  Line   view_mode_switch.install                    
 ------ -------------------------------------------- 
  66     No error to ignore is reported on line 66.  
 ------ -------------------------------------------- 
 [ERROR] Found 3 errors

Steps to reproduce

  • Check output of recent PHPStan job(s) in CI

Proposed resolution

  • Fix code quality issues

Remaining tasks

  • Create patch/MR to fix the code quality issues

User interface changes

n/a

API changes

n/a

Data model changes

n/a

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany hctom

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024